1018891 - [VR] When user is calling to a contact, contact's name isn't correct vertical alignment and type of phone is lowercase first letter

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Loli (:lolimartinezcr)]

Attachment: 2014-06-02-11-53-35.png

Tested
Hamachi
2.0
Gecko: 3e5340d
Gaia: 7416a20

Reproducible: 100%

Pre-requesites: contact saved.

STRs:
1. Tap dialer application.
2. Tap contacts button.
3. Tap in contact saved.
4. Tap Phone button.

Actual result:
See attached image. Contact's name isn't correctly alignment and user can see "mobile" instead "Mobile"

Expected result:
Contact's name is correctly alignment and user can see "Mobile" (first letter in uppercase).

Comment 1

[Germán Toro del Valle (:gtorodelvalle)]

Hi Loli, the contact name issue will be fixed once bug 1007709 lands. I will fix the first capital letter of the type of phone in this bug.

Comment 2

[Germán Toro del Valle (:gtorodelvalle)]

Hi Loli, isn't this bug fixed due to the patch for bug 1007709? Thanks! :)

Comment 3

[Maria Angeles Oteo (:oteo)]

In today's latest 2.0 build I continue seeing "mobile","home"... so the first letter in the "type of phone" label is not a capital letter in the Call screen and bug 1007709 was uplifted to 2.0 some days ago :(

Comment 4

[Loli (:lolimartinezcr)]

Tested and working
Hamachi
2.1
Gecko-c0de5b2
Gaia-eca491b

Hamachi
2.0
Gecko-eceb731
Gaia-e935f4f

Comment 5

[Loli (:lolimartinezcr)]

(In reply to Loli from comment #4)
> Tested and working
> Hamachi
> 2.1
> Gecko-c0de5b2
> Gaia-eca491b
> 
> Hamachi
> 2.0
> Gecko-eceb731
> Gaia-e935f4f

Sorry, It is working in 2.1 but *not* in 2.0. For this reason I reopen it pending 2.0

Comment 6

[Germán Toro del Valle (:gtorodelvalle)]

Hi guys, I spent some time having a look at this issue and came up with a question and a comment :)
  - Question: Wasn't the vertical alignment issue related to some bug or patch Vivien was working on some days ago, Mari Ángeles? Was it uplifted to 2.0 if any?
  - Comment: I found bug 1032502 which is still pending uplifting to 2.0. I would suggest re-testing this bug once that patch is uplifted.
Thanks!

Comment 7

[Maria Angeles Oteo (:oteo)]

hi German, I was not sure about what the vertical alignment was related to in this bug:(
but yes, Etienne fixed the issue "[Call Screen] UI moved up when entering another apps and back to call screen" in bug 1023794 and was uplifted to 2.0 last week, so that's the reason this is already fixed.

If you confirm that bug 1023794 fixes the uppercase letter issue, I think we can resolve this bug as worksforme

Comment 8

[Germán Toro del Valle (:gtorodelvalle)]

Hi Loli, would you be so kind to re-test this bug in 2.0 to see if it is solved, please? :) Thanks! (need-info me if it is not, please)

Comment 9

[Loli (:lolimartinezcr)]

(In reply to Germán Toro del Valle (on PTO today) from comment #8)
> Hi Loli, would you be so kind to re-test this bug in 2.0 to see if it is
> solved, please? :) Thanks! (need-info me if it is not, please)

Tested and working
Hamachi
2.0
Gecko-7a31c32
Gaia-1bd6e89