1018908 - Use JS_FRIEND_DATA only on global variable declarations, not on their instances, to fix compilation with mingw.

Status: RESOLVED DUPLICATE of bug 1019003

(Core :: JavaScript Engine, defect)

Description

[Jacek Caban]

It seems like GCC can't handle dllimport in this case and I get errors like:

0:02.30 /home/jacek/mozilla/mozilla-central/js/src/vm/TypedArrayObject.cpp:2098:37: error: external linkage required for symbol ‘js::detail::Int8ArrayClassPtr’ because of ‘dllexport’ attribute
 0:02.30  IMPL_TYPED_ARRAY_JSAPI_CONSTRUCTORS(Int8, int8_t)
 0:02.30                                      ^
 0:02.30 /home/jacek/mozilla/mozilla-central/js/src/vm/TypedArrayObject.cpp:2095:54: note: in definition of macro ‘IMPL_TYPED_ARRAY_JSAPI_CONSTRUCTORS’
 0:02.30    JS_FRIEND_DATA(const js::Class* const) js::detail::Name ## ArrayClassPtr =                    \
 0:02.30                                                       ^
 0:02.30 /home/jacek/mozilla/mozilla-central/js/src/vm/TypedArrayObject.cpp:2099:37: error: external linkage required for symbol ‘js::detail::Uint8ArrayClassPtr’ because of ‘dllexport’ attribute
 0:02.30  IMPL_TYPED_ARRAY_JSAPI_CONSTRUCTORS(Uint8, uint8_t)

Having the attribute on extern declaration should be enough.

Comment 1

[Jeff Walden [:Waldo]]

You have the chronologically older bug.  But in finally getting to reviewing patches after a long deviation into security work, I picked up bug 1019003's review first, which makes this a dup.

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 8432427 [details] [diff] [review]
fix

Review of attachment 8432427 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the duplication of effort here.  :-(