1019018 - Get rid of the Thebes backed gfxContext in AndroidBridge

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8432565 [details] [diff] [review]
patch

Review of attachment 8432565 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed and verification to make sure tab thumbnailing in Fennec still works.

::: widget/android/AndroidBridge.cpp
@@ +1854,5 @@
>      context->Translate(pt);
>      context->Scale(scale * bufW / srcW, scale * bufH / srcH);
>      rv = presShell->RenderDocument(r, renderDocFlags, bgColor, context);
>      if (is24bit) {
> +        gfxUtils::ConvertBGRAtoRGBA(buffer);

I think this needs to operate on "data" rather than "buffer". Also, looking at the signature of ConvertBGRAtoRGBA, it should passing a length parameter too? (bufW * bufH probably)

Comment 3

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/027e0de4304c

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/027e0de4304c