Closed Bug 1019018 Opened 6 years ago Closed 6 years ago

Get rid of the Thebes backed gfxContext in AndroidBridge

Categories

(Core :: Graphics, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

No description provided.
Attached patch patchSplinter Review
Attachment #8432565 - Flags: review?(bugmail.mozilla)
Comment on attachment 8432565 [details] [diff] [review]
patch

Review of attachment 8432565 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed and verification to make sure tab thumbnailing in Fennec still works.

::: widget/android/AndroidBridge.cpp
@@ +1854,5 @@
>      context->Translate(pt);
>      context->Scale(scale * bufW / srcW, scale * bufH / srcH);
>      rv = presShell->RenderDocument(r, renderDocFlags, bgColor, context);
>      if (is24bit) {
> +        gfxUtils::ConvertBGRAtoRGBA(buffer);

I think this needs to operate on "data" rather than "buffer". Also, looking at the signature of ConvertBGRAtoRGBA, it should passing a length parameter too? (bufW * bufH probably)
Attachment #8432565 - Flags: review?(bugmail.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/027e0de4304c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.