Closed Bug 1019091 Opened 5 years ago Closed 5 years ago

~CallSetup (destructor) should minimize work in the non-exception case

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

We're doing some JSAutoCompartment bits, saving/restoring of frame chains, etc.  We should try to avoid that.
Blocks: 1019081
Comment on attachment 8432689 [details] [diff] [review]
Do less work in the CallSetup destructor when we have no exception

Review of attachment 8432689 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that

::: dom/bindings/CallbackObject.cpp
@@ +216,5 @@
>  
>    // Now, if we have a JSContext, report any pending errors on it, unless we
>    // were told to re-throw them.
>    if (mCx) {
> +    bool dealtWithPendingException = !JS_IsExceptionPending(mCx);

Can we rename this variable dealWithException or something? With the current name, the correct value in the no-exception case is kind of unclear.
Attachment #8432689 - Flags: review?(bobbyholley) → review+
https://hg.mozilla.org/mozilla-central/rev/019f004523b5
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [need review]
Target Milestone: --- → mozilla32
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.