Closed Bug 1019114 Opened 10 years ago Closed 7 years ago

Consider using memcmp for string matching on Linux too

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1403911

People

(Reporter: jandem, Unassigned)

Details

StringMatch in jsstr.cpp can use memcmp if the pattern is large (length > 128), but this is currently disabled on Linux:

     * FIXME: Linux memcmp performance is sad and the manual loop is faster.

We should measure this again to see if it's still true and if not remove the #ifdef.

Hannes, since you're on Linux and mentoring a string matching bug, maybe you're interested in testing this? :)
Still an issue. Measured it last week.
memcpy was enabled in bug 1403911, performance seems to be okay (bug 1403911, comment #2).
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.