1019120 - [camera] Recorded video in secure mode doesn't appear in Gallery

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Tiffanie Shakespeare [:tif]]

STR
1. Set passcode for locked phone
2. Hit power button and observe locked device
3. Tap camera icon and switch to video mode
4. Start recording and hit home button
5. Observe (hopefully) that record stops (if not there is a bug 1018448)
6. Unlock phone and go to Gallery app

Expected
Video taken would appear in Gallery as per usual

Actual
Video taken is not there, but opening the Video app reveals the video was saved

Comment 1

[Marcia Knous [:marcia]]

Tiffanie: I don't see this using the Flame and:

Gaia   82679a5ce84d1b6bf388da6536d5682a3ad56de3
SourceStamp 6a984e21c2ca
BuildID 20140602072051
Version 32.0a1
Base Image: 10G

In my case the video is in the gallery when I unlock the device.

Comment 2

[Tiffanie Shakespeare [:tif]]

Hi Marcia! I'm also on the Flame and was just able to repro, my info is below. Hit me up on IRC to discuss. Thanks!

Your Target Build: PVT.master.flame
URL:  https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-central-flame-eng/latest/
ENG Ver: true
Flash: Gaia, Gecko, 
tshakespeare-17453:B2G-flash-tool tshakespeare$ ./check_versions.sh
Gaia      82679a5ce84d1b6bf388da6536d5682a3ad56de3
Gecko     https://hg.mozilla.org/mozilla-central/rev/6a984e21c2ca
BuildID   20140602072051
Version   32.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

Comment 3

[Tiffanie Shakespeare [:tif]]

Still able to repro on the build I flashed today

Flame
Gaia      857129928b6e56a809cee9d5445effb8fa9f1c2c
Gecko     https://hg.mozilla.org/mozilla-central/rev/c8288d0c7a15
BuildID   20140606040202
Version   32.0a1

Comment 4

[Jason Smith [:jsmith]]

I was able to reproduce this on today's 2.0 build.

Comment 5

[Jason Smith [:jsmith]]

(In reply to Jason Smith [:jsmith] from comment #4)
> I was able to reproduce this on today's 2.0 build.

Although in my case, the video didn't show up in the gallery app & video app.

Comment 6

[Justin D'Arcangelo [:justindarc]]

Able to reproduce in today's 2.0 build. The recorded video shows up in the Video app, but not the Gallery app.

Gaia      12af93123c5db55212d51fe235d39f21209a1eaa
Gecko     https://hg.mozilla.org/mozilla-central/rev/9305a8ec77fe
BuildID   20140609040203
Version   32.0a1

Comment 7

[Jason Smith [:jsmith]]

QA Wanted to check 1.4.

Comment 8

[Montoya Clemmons (MClemmons)]

(In reply to Jason Smith [:jsmith] from comment #7)
> QA Wanted to check 1.4.

This issue reproduces on 1.4 Flame. Following Comment 0 STR, Video taken is not within the Gallery App, but opening the Video app reveals the video was saved. 

Environmental Variables:
Device: Flame 1.4
Build ID: 20140610000204
Gaia: 57c6a24f7c7d16aac132f3cecd3ff9ee8d53cf78
Gecko: 54a7aa1a0423
Version: 30.0 (1.4) 
Firmware Version: v10G-2
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Comment 9

[Jason Smith [:jsmith]]

What about 1.3?

Comment 10

[Dean R. Gomez (DeanG)]

This issue DOES reproduce on Flame 1.3.  Video taken is not within the Gallery or Video app.

1.3 Environmental Variables:
Device: Flame 1.3
Build ID: 20140520094859
Gaia: a73235d23685e9898f40647cebd83b3fcbfd0117
Gecko: b637b0677e15318dcce703f0358b397e09b018af
Version: 28.0 (1.3) 
Firmware Version: v10G-2

Comment 11

[Joshua Mitchell (Inactive)]

QA-Wanted to also check 2.0 Buri

Comment 12

[Dean R. Gomez (DeanG)]

This issue DOES reproduce on Buri 2.0. Video taken is not within the Gallery or Video app.

2.0 Environmental Variables:
Device: Buri 2.0
Build ID: 20140609103029
Gaia: d283b742a12ac43ec087f45b02d3817cf7ddab69
Gecko: 68ac46c1b1f7
Version: 32.0a1 (2.0) 
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 13

[Joshua Mitchell (Inactive)]

QA-Wanted - almost done. Need to check Buri 1.4 and if that repros then check Buri 1.3

Comment 14

[Dean R. Gomez (DeanG)]

This issue DOES reproduce on Buri 1.4. Video taken is not within the Gallery or Video app.

1.4 Environmental Variables:
Device: Buri 1.4
Build ID: 20140612063006
Gaia: 80bf1039c6ce8bcde57ce06ecb09e40c18c538c6
Gecko: 39b6237907d9
Version: 30.0 (1.4) 
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0


This issue DOES reproduce on Buri 1.3. Video taken is not within the Gallery or Video app.

1.3 Environmental Variables:
Device: Buri 1.3
Build ID: 20140612002831
Gaia: 20cce4e5dd3ca7dfffc82ce1dce71741dd446952
Gecko: 233d0d0ea774
Version: 28.0 (1.3) 
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:28.0) Gecko/28.0 Firefox/28.0

Comment 15

[Joshua Mitchell (Inactive)]

Issue is present in all Flame and Buri Branches (2.0,1.4,1.3)

Not a regression

Comment 16

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (master)

The root cause of this issue was due to the face that `SecureWindowManager` was terminating secure apps (in this case, Camera) immediately upon tapping the 'Home' button. This resulted in the Camera app being terminated before the video file write operation could be properly closed. The Camera app already has the ability to stop recording video as soon as the app loses focus, so this patch makes `SecureWindowManager` perform a `close()` operation on the app, waits 5 seconds and then performs a `kill()` to terminate the process. This gives the Camera app enough time to successfully complete the file writing.

Comment 17

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8440917 [details] [review]
pull-request (master)

Please fix the unit tests. And if you tap the camera after you close it quickly, you will have two secure window instances for camera, please make sure they do not compete each other.

Comment 18

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8440917 [details] [review]
pull-request (master)

Alive, I have updated the PR to handle the termination of secure apps a little more gracefully. I've also updated the unit tests (they pass locally, waiting for results on Gaia-Try now). Please review when you get a chance.

Comment 19

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8440917 [details] [review]
pull-request (master)

Great, r+ with nit.

Comment 20

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/76c0f328d9c1069c187dcbbb20575c57013683bf

Comment 22

[Justin D'Arcangelo [:justindarc]]

[Blocking Requested - why for this release]:

Blocking Bug 1068540 since this patch was never uplifted to v2.0.

Comment 23

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (v2.0)

Patch rebased for v2.0 -- Carrying R+ forward

Comment 24

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8501267 [details] [review]
pull-request (v2.0)

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): none
[User impact] if declined: Recorded videos may become inaccessible via Camera and Gallery apps if recorded from a secured lockscreen
[Testing completed]: Tested on Flame-v184, green unit tests
[Risk to taking this patch] (and alternatives if risky): low -- this patch has existed on v2.1 and master for some time now with no known negative impact
[String changes made]:

Comment 25

[Justin D'Arcangelo [:justindarc]]

Landed on v2.0:

https://github.com/mozilla-b2g/gaia/commit/94638b51a5a5d513e26247e9b207aa54e7bb0568

Comment 26

[Kai-Zhen Li [:seinlin][:kli]]

v2.0m: https://github.com/mozilla-b2g/gaia/commit/4a1add3baecbc1028346e6b8520852b366e3812b

Comment 27

[Yeojin Chung [:YeojinC]]

This issue is verified on Flame 2.0,2.1,2.2.

Result: Video taken during the lockscreen appears in both Gallery and Video app.

Device: Flame 2.0 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141029000205
Gaia: 9f5b6f025e528fabfcc068782cb9b492cb51a7f9
Gecko: de8cfd54bf93
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 32.0 (2.0)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141029001202
Gaia: eb0aab0f13c78c7ac378ad860e865c4b6eaf669f
Gecko: 318019f80a8e
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141029040208
Gaia: 35e87ac4324f0f3abd93dcc70d61c9f37256a0f5
Gecko: 7e3c85754d32
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 36.0a1 (2.2 Master)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Comment 28

[Coler]

Verify passed, this issue can't be repro on Woodduck 2.0.
Attached: Verify_Woodduck_LockVideo.mp4
Reproducing rate: 0/5

Woodduck build:
Gaia-Rev        cc690f8016b672475dc186bc7fd58aef45e684b7
Gecko-Rev       03d3ab62d5b07b915434f2d1d68495ad5915ecd2
Build-ID        20141118184148
Version         32.0

Comment 29

[Coler]

Attachment: Verify_Woodduck_LockVideo.MP4