1019124 - HDPI support for Canvas Debugger

Status: RESOLVED FIXED

(DevTools Graveyard :: Canvas Debugger, defect)

Comment 1

[Tim Nguyen :ntim]

Attachment: Patch

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8432666 [details] [diff] [review]
Patch

Review of attachment 8432666 [details] [diff] [review]:
-----------------------------------------------------------------

This doubles the size of the buttons (see screenshot).  To test this, you can open canvas tool on a URL like http://madebyevan.com/webgl-water/ and press the capture button.

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: canvas-2x.png

Screenshot of canvas inspector at 2x with patch applied

Comment 4

[Brian Grinstead [:bgrins]]

I think this is the same thing we ran into with the net monitor in Bug 1012139

Comment 5

[Tim Nguyen :ntim]

Attachment: Patch v1.1

Fixed issue.

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8432668 [details] [diff] [review]
Patch v1.1

Review of attachment 8432668 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM - let Victor take a look before proceeding

Comment 7

[Brian Grinstead [:bgrins]]

Please update the commit message to include reviewer(s) and push to try before marking checkin-needed

Comment 8

[Tim Nguyen :ntim]

Attachment: Patch v1.2 (r=bgrins,vporof)

Comment 9

[Tim Nguyen :ntim]

Pushed to try : https://tbpl.mozilla.org/?tree=Try&rev=78954de8a8c6

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/d061de3ca26f

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d061de3ca26f