Closed Bug 1019124 Opened 7 years ago Closed 7 years ago

HDPI support for Canvas Debugger

Categories

(DevTools Graveyard :: Canvas Debugger, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 32

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(2 files, 2 obsolete files)

No description provided.
Attached patch Patch (obsolete) — Splinter Review
Attachment #8432666 - Flags: review?(vporof)
Attachment #8432666 - Flags: review?(bgrinstead)
Comment on attachment 8432666 [details] [diff] [review]
Patch

Review of attachment 8432666 [details] [diff] [review]:
-----------------------------------------------------------------

This doubles the size of the buttons (see screenshot).  To test this, you can open canvas tool on a URL like http://madebyevan.com/webgl-water/ and press the capture button.
Attachment #8432666 - Flags: review?(vporof)
Attachment #8432666 - Flags: review?(bgrinstead)
Attachment #8432666 - Flags: review-
Attached image canvas-2x.png
Screenshot of canvas inspector at 2x with patch applied
I think this is the same thing we ran into with the net monitor in Bug 1012139
Attached patch Patch v1.1 (obsolete) — Splinter Review
Fixed issue.
Attachment #8432666 - Attachment is obsolete: true
Attachment #8432668 - Flags: review?(vporof)
Attachment #8432668 - Flags: review?(bgrinstead)
Comment on attachment 8432668 [details] [diff] [review]
Patch v1.1

Review of attachment 8432668 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM - let Victor take a look before proceeding
Attachment #8432668 - Flags: review?(bgrinstead) → review+
Attachment #8432668 - Flags: review?(vporof) → review+
Please update the commit message to include reviewer(s) and push to try before marking checkin-needed
Attachment #8432668 - Attachment is obsolete: true
Attachment #8432679 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d061de3ca26f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.