Closed Bug 1019158 Opened 6 years ago Closed 6 years ago

crash in java.lang.NullPointerException: at org.mozilla.gecko.Telemetry.sendUIEvent(Telemetry.java)

Categories

(Firefox for Android :: General, defect, critical)

32 Branch
All
Android
defect
Not set
critical

Tracking

()

VERIFIED FIXED
Firefox 32
Tracking Status
firefox31 --- unaffected
firefox32 + verified
fennec 32+ ---

People

(Reporter: aaronmt, Assigned: mcomella)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file, 1 obsolete file)

This bug was filed from the Socorro interface and is 
report bp-d8f47a3a-09e2-41c5-9cb1-8deb22140601.
=============================================================

java.lang.NullPointerException
	at org.mozilla.gecko.Telemetry.sendUIEvent(Telemetry.java:161)
	at org.mozilla.gecko.Telemetry.sendUIEvent(Telemetry.java:168)
	at org.mozilla.gecko.Telemetry.sendUIEvent(Telemetry.java:176)
	at org.mozilla.gecko.preferences.PanelsPreferenceCategory.setDefault(PanelsPreferenceCategory.java:165)
	at org.mozilla.gecko.preferences.PanelsPreference.onDialogIndexClicked(PanelsPreference.java:122)
	at org.mozilla.gecko.preferences.CustomListPreference$2.onClick(CustomListPreference.java:123)
	at com.android.internal.app.AlertController$AlertParams$3.onItemClick(AlertController.java:941)
	at android.widget.AdapterView.performItemClick(AdapterView.java:299)
	at android.widget.AbsListView.performItemClick(AbsListView.java:1158)
	at android.widget.AbsListView$PerformClick.run(AbsListView.java:2957)
	at android.widget.AbsListView$3.run(AbsListView.java:3850)
	at android.os.Handler.handleCallback(Handler.java:733)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:136)
	at android.app.ActivityThread.main(ActivityThread.java:5103)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:515)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:790)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:606)
	at dalvik.system.NativeStart.main(Native Method)
        final GeckoEvent geckoEvent = GeckoEvent.createTelemetryUIEvent(
                eventName, method.toString(), timestamp, extras);


method is null. mcomella!
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
tracking-fennec: --- → 32+
Blocks: 1009315
I'm a silly goose.
Attachment #8432721 - Flags: review?(rnewman)
Comment on attachment 8432721 [details] [diff] [review]
Don't send null methods into UITelemetry.

Review of attachment 8432721 [details] [diff] [review]:
-----------------------------------------------------------------

Let's also have sendUIEvent check for null (don't care whether it defaults to Method.NONE or throws), and document that in the docstring. Fix bugs from the inside out.
Attachment #8432721 - Flags: review?(rnewman) → review+
Attachment #8432721 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/ab97b9288474
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Flags: in-moztrap?(ioana.chiorean)
QA Contact: ioana.chiorean
Hit this myself on Nightly 06/03 (w/o ab97b9288474) via changing system language.

TODO: VERIFY-FIXED on Nightly 06/04.
I can reproduce the crash after going in Settings -> Customize -> Home and set a panel as default. (06/03)
Not reproducible with 06/04 build.
Status: RESOLVED → VERIFIED
Flags: in-moztrap?(ioana.chiorean)
You need to log in before you can comment on or make changes to this bug.