Shut up stupid NSS build spam

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: vlad, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 8432823 [details] [diff] [review]
Quiet NSS build

I am incredibly sick of seeing:

There are no private exports.
There are no private exports.
There are no private exports.
cd params; c:/Users/vladimir/bin/mozmake private_export
cd params; c:/Users/vladimir/bin/mozmake private_export
cd params; c:/Users/vladimir/bin/mozmake export
There are no private exports.
There are no private exports.
There are no private exports.
cd results; c:/Users/vladimir/bin/mozmake private_export
cd results; c:/Users/vladimir/bin/mozmake private_export
cd results; c:/Users/vladimir/bin/mozmake export
There are no private exports.
cd store; c:/Users/vladimir/bin/mozmake private_export
There are no private exports.
There are no private exports.
cd store; c:/Users/vladimir/bin/mozmake private_export
cd store; c:/Users/vladimir/bin/mozmake export
There are no private exports.
cd top; c:/Users/vladimir/bin/mozmake private_export
There are no private exports.
There are no private exports.
cd top; c:/Users/vladimir/bin/mozmake private_export
cd top; c:/Users/vladimir/bin/mozmake export
There are no private exports.
cd util; c:/Users/vladimir/bin/mozmake private_export
There are no private exports.
There are no private exports.
There are no private exports.
cd util; c:/Users/vladimir/bin/mozmake export
cd util; c:/Users/vladimir/bin/mozmake private_export
etc.

This just needs to die.
Attachment #8432823 - Flags: review?(benjamin)
Comment on attachment 8432823 [details] [diff] [review]
Quiet NSS build

Review of attachment 8432823 [details] [diff] [review]:
-----------------------------------------------------------------

NSS is its own module, with different peers than the build system.

::: security/nss/coreconf/rules.mk
@@ +771,4 @@
>  	$(INSTALL) -m 444 $^ $(PRIVATE_EXPORT_DIR)
>  else
>  private_export:: 
> +	$(NULL)

That shouldn't be needed.

@@ +771,5 @@
>  	$(INSTALL) -m 444 $^ $(PRIVATE_EXPORT_DIR)
>  else
>  private_export:: 
> +	$(NULL)
> +#	@echo There are no private exports.;

If you want to remove something, don't comment it, remote it ;)
Attachment #8432823 - Flags: review?(benjamin) → review?(brian)
Component: Build Config → Build
Product: Core → NSS
Version: unspecified → trunk
Comment on attachment 8432823 [details] [diff] [review]
Quiet NSS build

Review of attachment 8432823 [details] [diff] [review]:
-----------------------------------------------------------------

This annoying output is an indicator of inefficiencies in the NSS build process. If we remove the output then those inefficiencies will be (further) hidden. This part, in particular, is really slow on Windows. A better way of getting rid of this annoying output would be to centralize all the exports into a single, efficient, Makefile rule.

That said, r- for the reasons Mike noted, but I am happy to r+ the removal of these print statements, unless anybody else objects.

::: security/nss/coreconf/rules.mk
@@ +771,5 @@
>  	$(INSTALL) -m 444 $^ $(PRIVATE_EXPORT_DIR)
>  else
>  private_export:: 
> +	$(NULL)
> +#	@echo There are no private exports.;

I agree with Mike's comments.

::: security/nss/coreconf/ruleset.mk
@@ +204,4 @@
>  
>  ifdef DIRS
>  define SUBMAKE
> +#+@echo "cd $2; $(MAKE) $1"

Ditto here; don't comment it out; remove it.
Attachment #8432823 - Flags: review?(brian) → review-
NSS is built with GYP these days.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.