1019268 - [privacy] Existing users must sign the privacy policy

Status: VERIFIED FIXED

(Mozilla QA Graveyard :: One and Done, defect, P1)

Description

[Rebecca Billings [:rbillings]]

Upon signing in, all existing users must be presented with the privacy policy. They cannot continue with the tool without accepting the PP.

The pop-up should contain the link to the standard Mozilla PP in addition to the checkbox for contact [matching bug 1006569]

Comment 1

[Bob Silverberg [:bsilverberg]]

Releasing this for now to focus on other bugs.

Comment 2

[Bob Silverberg [:bsilverberg]]

Because we are also adding the "profile url" field, we should give existing users a chance to edit that as well. I think it makes sense to use the screen described in bug 1006569 for that purpose as well, as it will ask users to accept the privacy policy and also to create a Display Name and a Profile URL (once I update that bug).

Comment 3

[Rebecca Billings [:rbillings]]

+1

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

bitgeeky, are you working on this one?  If you are can you assign it to yourself?  If not, no worries :)

Comment 5

[Pankaj Malhotra (:bitgeeky)]

This will be covered along with https://github.com/mozilla/oneanddone/pull/130 in bug 1006569  but still let this bug be open for now. I will mark it resolved when the pull request gets merged.

Comment 6

[Bob Silverberg [:bsilverberg]]

This bug now covers just the issue of forcing existing users to sign the privacy policy.

For any existing user, they should be presented with the same screen as those signing up for the first time whenever they try to access any area of the site that is not publicly available. They should not be allowed to access any of those private areas until they check the box saying that they accept the privacy policy.

We should provide a link to allow them to delete their account if they do not wish to sign the privacy policy. I suggest this be added under the check box, and only appear for users who already have an account but have not yet accepted the privacy policy.

Comment 7

[Rebecca Billings [:rbillings]]

This bug is specifically about making existing users sign the privacy policy. A new bug can be opened to offer them the option of deleting their profile from the PP page [as opposed to doing it within the tool] for V2 milestone 2. The delete option from the PP page is a nice to have, but is outside of the original scope.

Comment 8

[Pankaj Malhotra (:bitgeeky)]

We already have a bug for Delete profile Bug 1005127  :-)

Comment 9

[Pankaj Malhotra (:bitgeeky)]

Attachment: Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/140

Works fine for me.
Modified an existing unit test and added one more.

Comment 10

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8446185 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/140

Only one small change required.

Comment 11

[Pankaj Malhotra (:bitgeeky)]

Comment on attachment 8446185 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/140

Made the suggested change. Please review.

Comment 12

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8446185 [details] [review]
Link to Github pull-request: https://github.com/mozilla/oneanddone/pull/140

Landed in https://github.com/mozilla/oneanddone/commit/1374a5fe10f38baa686f40c95d18c456352ee568

Comment 13

[Rebecca Billings [:rbillings]]

I tested this earlier, if possible I'd like to re-set my/some test user to this state to re-test prior to the release. Or give me ideas on how I could get a user into this state of my own doing. Thanks!

Comment 14

[Bob Silverberg [:bsilverberg]]

I have added the UserProfile to the admin, so you can go in and change the privacy_policy_accepted flag for any existing user.

Comment 15

[Rebecca Billings [:rbillings]]

Perfect! Verified all users must accept PP, able to delete profile, or save it and return to profile with previous task history.