Closed
Bug 1019381
Opened 7 years ago
Closed 7 years ago
Cherrypick clang and gcc warning fixes from upstream jemalloc
Categories
(Core :: Memory Allocator, defect)
Core
Memory Allocator
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
6.25 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
This patch fixes the following warnings I see when building Firefox for Android (gcc) and OS X (clang): src/prof.c:1070:11 [-Wsign-compare] comparison of integers of different signs: 'int64_t' (aka 'long long') and 'unsigned long long' src/util.c:179:55 [-Wsign-compare] comparison of integers of different signs: 'uintmax_t' (aka 'unsigned long') and 'int' src/util.c:180:60 [-Wsign-compare] comparison of integers of different signs: 'uintmax_t' (aka 'unsigned long') and 'int' src/util.c:181:60 [-Wsign-compare] comparison of integers of different signs: 'uintmax_t' (aka 'unsigned long') and 'int' src/util.c:551:35 [-Wsign-compare] signed and unsigned type in conditional expression src/util.c:502:5 [-Wsometimes-uninitialized] variable 'val' is used uninitialized whenever switch default is taken src/util.c:512:5 [-Wsometimes-uninitialized] variable 'val' is used uninitialized whenever switch default is taken src/util.c:521:5 [-Wsometimes-uninitialized] variable 'val' is used uninitialized whenever switch default is taken src/util.c:530:5 [-Wsometimes-uninitialized] variable 'val' is used uninitialized whenever switch default is taken I fixed these warnings in upstream jemalloc here: https://github.com/jemalloc/jemalloc/pull/86
Attachment #8433048 -
Flags: review?(mh+mozilla)
Comment 1•7 years ago
|
||
Comment on attachment 8433048 [details] [diff] [review] jemalloc-warnings.patch Review of attachment 8433048 [details] [diff] [review]: ----------------------------------------------------------------- You need to add a patch in memory/jemalloc, and reference it in memory/jemalloc/update.sh.
Attachment #8433048 -
Flags: review?(mh+mozilla) → feedback+
Comment 2•7 years ago
|
||
(BTW, if you feel like looking at the warnings building on windows emits, be my guest ;) )
Assignee | ||
Comment 3•7 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #1) > You need to add a patch in memory/jemalloc, and reference it in > memory/jemalloc/update.sh. Do we need an in-tree patch even though these fixes are already in jemalloc upstream? The next time we update our in-tree copy of jemalloc, these fixes won't need to be restored with a local patch.
Flags: needinfo?(mh+mozilla)
Comment 4•7 years ago
|
||
(In reply to Chris Peterson (:cpeterson) from comment #3) > (In reply to Mike Hommey [:glandium] from comment #1) > > You need to add a patch in memory/jemalloc, and reference it in > > memory/jemalloc/update.sh. > > Do we need an in-tree patch even though these fixes are already in jemalloc > upstream? All the in-tree patches are already in jemalloc upstream. Still, we want that running update.sh without updating upstream.info yields the same tree.
Flags: needinfo?(mh+mozilla)
Assignee | ||
Comment 5•7 years ago
|
||
Patch v2 adds in-tree patch 0004-Fix-clang-warnings.patch and references it in update.sh.
Attachment #8433048 -
Attachment is obsolete: true
Attachment #8433907 -
Flags: review?(mh+mozilla)
Updated•7 years ago
|
Attachment #8433907 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 6•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/257269554ad9
status-firefox31:
--- → wontfix
status-firefox32:
--- → fixed
Comment 7•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/257269554ad9
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•