Don't blocklist D2D for Catalyst 14.6 onward

VERIFIED FIXED in Firefox 32

Status

()

Core
Graphics
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: bas, Assigned: bas)

Tracking

unspecified
mozilla32
x86_64
Windows 8.1
Points:
---

Firefox Tracking Flags

(firefox32 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
We blocklisted Direct2D for Catalyst 14.4 because of BSOD errors in bug 984488. It seems these issues have been resolved in 14.6 we only need to blocklist between those versions.
(Assignee)

Comment 1

4 years ago
Created attachment 8433068 [details] [diff] [review]
Only block D2D between Catalyst 14.4 and 14.6
Attachment #8433068 - Flags: review?(bjacob)
Comment on attachment 8433068 [details] [diff] [review]
Only block D2D between Catalyst 14.4 and 14.6

Review of attachment 8433068 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/GfxInfo.cpp
@@ +956,3 @@
>          (nsAString&) GfxDriverInfo::GetDeviceVendor(VendorAMD), GfxDriverInfo::allDevices,
>        nsIGfxInfo::FEATURE_DIRECT2D, nsIGfxInfo::FEATURE_BLOCKED_DRIVER_VERSION,
> +      DRIVER_BETWEEN_INCLUSIVE_START, V(14,1,0,0), V(14,2,0,0), "14.1.0.0");

The last argument (the string) is the suggestion of driver version to upgrade to. So "14.1.0.0" is wrong here. Also, since it's user-facing, it's better to use commercial driver version names there. I would put: "AMD Catalyst 14.6".
Attachment #8433068 - Flags: review?(bjacob) → review+
https://hg.mozilla.org/mozilla-central/rev/1b2acadf97b3
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Keywords: verifyme
QA Contact: florin.mezei
I've verified this with Firefox 32 Beta 8 (BuildID: 20140818191513) on Windows 7 x64 by spoofing the video data:
1. Create "spoofed-firefox.bat" file with following content:
SET MOZ_GFX_SPOOF_WINDOWS_VERSION=
SET MOZ_GFX_SPOOF_VENDOR_ID=
SET MOZ_GFX_SPOOF_DEVICE_ID=
SET MOZ_GFX_SPOOF_DRIVER_VERSION=
"C:\Mozilla\Firefox\firefox.exe" -p -no-remote
2. Set the IDs and versions values, saved the file, opened it to launch Firefox, created a new profile, started Firefox, and verified "about:support" -> Graphics.

ATI and AMD drivers between 14.1.0.0 and 14.1.9.9 (inclusive) have D2D blocked ("Blocked for your graphics driver version. Try updating your graphics driver to version ATI Catalyst 14.6+ or newer."), versions outside this interval are not blocked (except by other rules).

Data used and results can be found at https://docs.google.com/spreadsheets/d/12yEBqNZqaR6_2XbqFrVwRVxt_URjNN3iMmu-GX60Z0Q/edit#gid=0, lines 68 to 78.
Status: RESOLVED → VERIFIED
status-firefox32: --- → verified
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.