1019427 - Log scancode -> virtual keycode table for KeyboardEvent.code debug on Windows

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This is just an enhancement.

If you don't like this patch since this adding logging code into release build, please -'ing the review. Then, I'll mark this bug as INVA.

Here is a table which is created from the log:
https://docs.google.com/spreadsheets/d/1fx-53xXI0cKL-18Dly8oFfIXc7RCOsB_VvI90nrwxA8/edit?usp=sharing

If this logging code is in release build, we can request this to users who have a special keyboard.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Oops, I forgot to attach this patch at filing a bug. See comment 0 for the detail.

Comment 2

[Jim Mathies [:jimm]]

Comment on attachment 8433124 [details] [diff] [review]
Patch

Review of attachment 8433124 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/KeyboardLayout.cpp
@@ +2268,5 @@
> +          ::MapVirtualKeyEx(scanCode, kMapType, mKeyboardLayout);
> +        PR_LOG(sKeyboardLayoutLogger, PR_LOG_DEBUG,
> +               ("0x%04X, %s", scanCode, kVirtualKeyName[virtualKeyCode]));
> +      }
> +      if (!IsVistaOrLater()) {

this is kind of strange, the |for (uint32_t i = 0; i < ArrayLength(kExtendedScanCode); i++)| will do one iteration then exit on XP? Maybe add a comment here explaining this check.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/54b35d7d75ce

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/54b35d7d75ce