Add 'waitForNotificationUnload' method in locationBar class

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Daniel Gherasim, Unassigned, Mentored)

Tracking

Version 2

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lib][lang=js][good first bug], URL)

(Reporter)

Description

4 years ago
As discussed in bug 994040, a method to close notifications & wait for them to be completely unloaded would be nice to have in our toolbars.js/locationBar class.
When you want to have this a mentored bug, more information has to be specified. Best would be an example, and a pointer to the currently existing code. Right now it will be hard to understand for someone new in that project.
(Reporter)

Comment 2

4 years ago
Bug 994040 is fixed now so I'll give some more information here as requested.

What we need here is to add a new method in the locationBar class in this file:
http://hg.mozilla.org/qa/mozmill-tests/file/930bde25e81d/firefox/lib/toolbars.js#l319

that will replace the code in several tests, like this one:

http://hg.mozilla.org/qa/mozmill-tests/file/930bde25e81d/firefox/tests/functional/testPreferences/testPasswordSavedAndDeleted.js#l61

The method will look like:

waitForNotificationUnload() {
  // call waitForNotificationPanel method with the specific callback code to close the notification;
}
(In reply to daniel.gherasim from comment #2)
> waitForNotificationUnload() {
>   // call waitForNotificationPanel method with the specific callback code to
> close the notification;
> }

Why another wrapper here? I don't think this is worth, given that you still have to add the other aSpec values.

Updated

4 years ago
Mentor: andreea.matei@softvision.ro
Whiteboard: [lib][mentor=andreea.matei][lang=js][good first bug] → [lib][lang=js][good first bug]

Comment 4

4 years ago
Hi, I am a Computing student that would like to be assigned this bug.
Hi Mustafa, thanks for your interest. Please see the comments for what the bug has to do and you can also get familiar with mozmill and mozmill tests with this documentation:
https://developer.mozilla.org/en-US/docs/Mozilla/QA/Mozmill_tests

Let me know if you have questions, here or on the #automation channel. Thanks!

Comment 6

4 years ago
Hi Andreea, does this mean I have been assigned to this bug can you please confirm that. Thank you.
Assignee: nobody → mustafa_adam1990
Status: NEW → ASSIGNED
Yes, I assigned you :)

Comment 8

4 years ago
Thank you Andreea :), quick question is it possible that you draw up a list for me of the things that are needed to fix this bug?

Regards
Mustafa
Actually, I'm afraid we don't need this change anymore since in bug 994040 we have implemented the unload of the notification in the same method. Can I suggest to you bug 882137? It's a refactoring one, to update the jsdoc for each function. If you have questions, lets move to that bug.
Assignee: mustafa_adam1990 → nobody
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Comment 10

4 years ago
thats a shame,  could you assign me to that one please and also tell me what is needed for it.
You need to log in before you can comment on or make changes to this bug.