Closed Bug 1019476 Opened 6 years ago Closed 6 years ago

Can't use an undefined value as an ARRAY reference (Bugzilla/User.pm:773)

Categories

(Bugzilla :: Bugzilla-General, defect, critical)

defect
Not set
critical

Tracking

()

RESOLVED INVALID

People

(Reporter: glob, Assigned: glob)

References

Details

Attachments

(1 file)

when viewing bugs with an empty cc list:

Can't use an undefined value as an ARRAY reference (Bugzilla/User.pm:773)
Attached patch 1019476_1.patchSplinter Review
Attachment #8433202 - Flags: review?(dkl)
Note that only BMO's Bugzilla::Bug->cc contains the line:

 $self->{'cc'} = undef if !scalar(@{$self->{'cc'}});

But upstream bugzilla does not, and $self->{'cc'} will always be defined. Git blame does not enlighten as to why this change is in BMO but not upstream.
Comment on attachment 8433202 [details] [diff] [review]
1019476_1.patch

Review of attachment 8433202 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl
Attachment #8433202 - Flags: review?(dkl) → review+
Flags: approval?
(In reply to Dylan William Hardison [:dylan] from comment #2)
> Note that only BMO's Bugzilla::Bug->cc contains the line:
>  $self->{'cc'} = undef if !scalar(@{$self->{'cc'}});
> But upstream bugzilla does not, and $self->{'cc'} will always be defined.
> Git blame does not enlighten as to why this change is in BMO but not
> upstream.

that line was removed by bug 819330 (bugzilla 4.4), which is why it's still present on bmo (bugzilla 4.2).
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: approval?
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.