1019476 - Can't use an undefined value as an ARRAY reference (Bugzilla/User.pm:773)

Status: RESOLVED INVALID

(Bugzilla :: Bugzilla-General, defect)

Description

[:glob ✱]

when viewing bugs with an empty cc list:

Can't use an undefined value as an ARRAY reference (Bugzilla/User.pm:773)

Comment 1

[:glob ✱]

Attachment: 1019476_1.patch

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Note that only BMO's Bugzilla::Bug->cc contains the line:

 $self->{'cc'} = undef if !scalar(@{$self->{'cc'}});

But upstream bugzilla does not, and $self->{'cc'} will always be defined. Git blame does not enlighten as to why this change is in BMO but not upstream.

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 8433202 [details] [diff] [review]
1019476_1.patch

Review of attachment 8433202 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 4

[:glob ✱]

(In reply to Dylan William Hardison [:dylan] from comment #2)
> Note that only BMO's Bugzilla::Bug->cc contains the line:
>  $self->{'cc'} = undef if !scalar(@{$self->{'cc'}});
> But upstream bugzilla does not, and $self->{'cc'} will always be defined.
> Git blame does not enlighten as to why this change is in BMO but not
> upstream.

that line was removed by bug 819330 (bugzilla 4.4), which is why it's still present on bmo (bugzilla 4.2).