1019479 - [Message]The recipient which originally display as contact name will display as phone number after viewing the recipient details of a draft.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[panda67231]

Attachment: 20140529_165358.mp4

[1.Description]:
After veiwing the recipient details of a draft, the recipient which originally display as contact name will display as phone number.
Attachment screenshoot:[recipient_1.jpg & recipient_2.jpg]
Attachment video:[20140529_165358.mp4]
Attachment log:[bugreport.txt]&[logcat.txt]

[2.Testing Steps]: 
Precondition：There is at least one contact saved with  name and telephone number.
1. Launch SMS from home and create a new SMS.
2. Tap "+"  icon 
3. Select a contact saved with both name and phone number as recipient
4. Tap this added recipient to view its details.
5. Save this SMS as draft
6. Reopen this draft SMS and preview its recipient details
7. Try to input other recipient



[3.Expected Result]: 
4&5.After clicking the result is the same and the recipients of the draft  SMS will not be changed 

[4.Actual Result]: 
4&5.Clicking on  the recipients  of the draft SMS  is different from clicking on the recipients of the  new SMS .And after clicking  on the recipients of the draft  SMS will be changed the phone number

[5.Reproduction build]: 
Gaia        7709936aeb21859d1607dbd038489493803bb085
Gecko     https://hg.mozilla.org/releases/mozilla-b2g30_v1_4/rev/5bf038fae0f1
BuildID    20140522160202
Version    30.0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

Comment 1

[panda67231]

Attachment: recipient_1.jpg

Comment 2

[panda67231]

Attachment: recipient_2.jpg

Comment 3

[panda67231]

Attachment: bugreport.txt

Comment 4

[panda67231]

Attachment: logcat.txt

Comment 5

[Julien Wajsberg [:julienw]]

This one is interesting, thanks !

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] azasypkin:bug-1019479-contact-recipient-in-draft > mozilla-b2g:master

Comment 8

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8592158 [details] [review]
[gaia] azasypkin:bug-1019479-contact-recipient-in-draft > mozilla-b2g:master

Hey Julien,

Looks like that problem is that we don't mark contact as "contact" when we restore it from the draft. So here is the small patch to fix this.

What do you think?

Comment 9

[Julien Wajsberg [:julienw]]

Comment on attachment 8592158 [details] [review]
[gaia] azasypkin:bug-1019479-contact-recipient-in-draft > mozilla-b2g:master

r=me to land this simple patch but I left some important questions about bigger changes in how our recipients are handled that I think we should handle. We can still land this simple patch that fixes this simple issue.

Comment 10

[Oleg Zasypkin [:azasypkin]]

(In reply to Julien Wajsberg [:julienw] (PTO April 6th) from comment #9)
> Comment on attachment 8592158 [details] [review]
> [gaia] azasypkin:bug-1019479-contact-recipient-in-draft > mozilla-b2g:master
> 
> r=me to land this simple patch but I left some important questions about
> bigger changes in how our recipients are handled that I think we should
> handle. We can still land this simple patch that fixes this simple issue.

Thanks for review! Replied at Github and since you agree, let's land this simple fix and generalize/fix our recipients logic further in the next patches.

Comment 11

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/3f704c06d52ecfcc3bf6333bae6fdf4bfdf0a08f

Comment 12

[zouyi(Leave from Mozilla)]

Attachment: verify_master.mp4

This bug has been verified as pass on latest build of Flame v3.0& Nexus5 v3.0.
See attachments:verify_master.mp4
Reproduce rate: 0/5

Device: Flame v3.0 build(pass)
Build ID               20150603160203
Gaia Revision          45dc6306cf502a4f00ae9f8bd8293a8a3a37c07b
Gaia Date              2015-06-03 17:32:50
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0920f2325a6d
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150603.192042
Firmware Date          Wed Jun  3 19:20:53 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus5 v3.0 build(pass)
Build ID               20150603160203
Gaia Revision          45dc6306cf502a4f00ae9f8bd8293a8a3a37c07b
Gaia Date              2015-06-03 17:32:50
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0920f2325a6d
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150603.193140
Firmware Date          Wed Jun  3 19:31:59 EDT 2015
Bootloader             HHZ12f