Stop creating a Thebes backed gfxContext in gfxQuartzNativeDrawing

RESOLVED FIXED in mozilla32

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

Trunk
mozilla32
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch remove cairo support (obsolete) — Splinter Review
No description provided.
Attachment #8433234 - Flags: review?(matt.woodrow)
gfxQuartzNativeDrawing is only used for drawing plugins and platform themes (as backgrounds), so this doesn't actually block bug 987190. It does block bug 933019 though.
Blocks: 933019
No longer blocks: 987190
Oops, yes, I copied the wrong bug number.
need to initialize mCGContext to null if we don't want the assertion in BeginNativeDrawing to fail
Attachment #8433234 - Attachment is obsolete: true
Attachment #8433234 - Flags: review?(matt.woodrow)
Attachment #8433298 - Flags: review?(matt.woodrow)
If we're still using Cairo for Moz2D, will this cause a problem?
No. When I wrote "Cairo" I meant a non-DrawTarget backed gfxContext.
Comment on attachment 8433298 [details] [diff] [review]
remave cairo support

Review of attachment 8433298 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxQuartzNativeDrawing.cpp
@@ +29,4 @@
>  
> +  if (mContext->IsCairo()) {
> +    // We're past that now. Any callers that still supply a Cairo context
> +    // don't deserve native theming.

Add a NS_WARNING or similar here just in case.
Attachment #8433298 - Flags: review?(matt.woodrow) → review+
https://hg.mozilla.org/mozilla-central/rev/adfd943ff73e
Assignee: nobody → mstange
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.