101958 - outliner drag-n-drop without changing columns sorts on that column

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[:deanis74]

Steps to reproduce:

1. In the message pane of Mail & News, start dragging the Subject column header
around.
2. Drag it back and forth, but don't let go of the mouse button.
3. Drag it back to its original position.
4. Let go of the mouse button.

Expected Results: Drag is canceled and nothing else happens.

Actual Results: Drag is canceled and the list is sorted by the Subject column.

This is getting treated as a click, probably because there's a mouse down on the
column header followed eventually by a mouse up.  If there's a drag of the
header in between there, that click event should be eaten.

Comment 1

[:deanis74]

Build is 2001092703 on Win2K.

Comment 2

[Not interested in Mozilla any more]

I'm also seeing this on MacOS using build 2001092804.

Comment 3

[Joe Hewitt (gone)]

Attachment: patch

This patch cancels the click event after a drag operation.

Comment 4

[Blake Ross]

Comment on attachment 58677 [details] [diff] [review]
patch

sr=blake if you remove the you-know-what-ism that we discussed

Comment 5

[jag (Peter Annema)]

Comment on attachment 58677 [details] [diff] [review]
patch

r=jag if you change the you-know-what-ism blake already pointed out, flip a bit
and fix the indentation on that whatchamacallit.

Comment 6

[Jan Varga [:janv]]

hmm, just when I wanted to comment :)
well I was asked for review too, so adding my comments

Looks good only some nits:

var bx =
col.parentNode.boxObject.QueryInterface(Components.interfaces.nsIOutlinerBoxObject)

don't we have |.outlinerBoxObject| property ?

I don't like timers, but if there's no other way ...

r=varga

Comment 7

[Joe Hewitt (gone)]

good point, Jan, that was pretty dumb.

fix checked in.