1019594 - Build script should check prerequisites before building

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect)

Description

[Johannes Bauer]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140428193603

Steps to reproduce:

I cloned a clean BRANCH=1.4 repo, did a ./config.sh hamachi and tried to run ./build.sh when adb was not installed.


Actual results:

Installation failed and complained about numerous files not having been found ("repo", "out/lastpatch.projects", "adb"). The first two are project internal (bug), the last one resulted because I didn't have adb installed. For reference:
including device/qcom/b2g_common/vendorsetup.sh
device/qcom/b2g_common/treeid.sh: line 42: repo: command not found
Tree IDs: all
device/qcom/b2g_common/vendorsetup.sh: line 62: repo: command not found
device/qcom/b2g_common/vendorsetup.sh: line 87: out/lastpatch.projects: No such file or directory

[entering gecko]
device/qcom/b2g_common/vendorsetup.sh: line 94: repo: command not found
Checking out files: 100% (16581/16581), done.
Previous HEAD position was 4d8a422... Bumping manifests a=b2g-bump
Branch master set up to track remote branch master from mozillaorg.
Switched to a new branch 'master'
error: branch 'b2g_autogen_ephemeral_branch' not found.
Switched to branch 'b2g_autogen_ephemeral_branch'
  device/qcom/b2g_common/patch/all/gecko/Update-callbacks-to-match-bluetooth.h.patch
Applying: Update callbacks to match bluetooth.h
  device/qcom/b2g_common/patch/all/gecko/widget-gonk-Add-ro.sf.lcd_density-DPI-override.patch
Applying: widget: gonk: Add ro.sf.lcd_density DPI override

============================================
PLATFORM_VERSION_CODENAME=AOSP
PLATFORM_VERSION=4.0.4.0.4.0.4
TARGET_PRODUCT=full_hamachi
TARGET_BUILD_VARIANT=eng
TARGET_BUILD_TYPE=release
TARGET_BUILD_APPS=
TARGET_ARCH=arm
TARGET_ARCH_VARIANT=armv7-a-neon
HOST_ARCH=x86
HOST_OS=linux
HOST_OS_EXTRA=Linux-3.11.0-12-generic-x86_64-with-LinuxMint-16-petra
HOST_BUILD_TYPE=release
BUILD_ID=OPENMASTER
OUT_DIR=out
============================================

Blob setup script has changed, re-running
Pulling files from device
./extract-files.sh: line 30: adb: command not found
Backing up system partition to backup-hamachi
./extract-files.sh: line 39: adb: command not found
Pulling "libOmxAacDec.so"
./extract-files.sh: line 89: adb: command not found
Failed to pull libOmxAacDec.so. Giving up.




Expected results:

build.sh should check that adb is actually installed before trying to execute it and print a sane error message. The other two internal tools should be included in the path or it should be made clear that missing them is okay (i.e. discard the error message to /dev/null). A message like

"build.sh needs to pull files from you connected phone using the adb utility, but adb was not found in your search path. Please install adb before continuing (e.g., for Ubuntu this program is provided by the package android-tools-adb)."

Lets the user immediately know what's up and how she can fix it.

Comment 1

[BMO Automation]

Firefox OS is not being worked on