1019604 - TypeError: coercing to Unicode: need string or buffer, NoneType found, following mochitest failure

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Geoff Brown [:gbrown]]

Recent logs in bug 915212 show this.

https://tbpl.mozilla.org/php/getParsedLog.php?id=40930768&full=1&branch=mozilla-inbound#error0

23:47:46     INFO -  Mochi-Remote INFO | Device info: {'uptime': ['0 days 0 hours 2 minutes 27 seconds 985 ms'], 'sutuserinfo': [], 'power': ['Power status:', ' AC power ONLINE', ' Battery charge CHARGING', ' Remaining charge: 50%', ' Battery Temperature: 0.0 (c)'], 'process': [['10015', '220', 'com.android.quicksearchbox'], ['10014', '354', 'com.svox.pico'], ['10019', '343', 'com.android.defcontainer'], ['10011', '118', 'com.android.inputmethod.latin'], ['1000', '64', 'system'], ['10006', '195', 'com.android.deskclock'], ['10032', '301', 'com.mozilla.SUTAgentAndroid'], ['10025', '136', 'com.android.launcher'], ['10001', '236', 'android.process.media'], ['10012', '274', 'com.android.email'], ['10000', '172', 'android.process.acore'], ['10027', '208', 'com.android.music'], ['10002', '228', 'com.android.protips'], ['10031', '284', 'com.mozilla.watcher'], ['1001', '123', 'com.android.phone'], ['10007', '256', 'com.android.mms'], ['1000', '158', 'com.android.settings'], ['1000', '124', 'com.android.systemui']], 'screen': ['X:1024 Y:816'], 'memory': ['PA:759246848, FREE: 643178496'], 'systime': ['2014/06/02 11:42:17:479'], 'rotation': ['ROTATION:0'], 'disk': ['/data: 610140160 total, 568524800 available', '/system: 203423744 total, 94285824 available', '/mnt/sdcard: 522225664 total, 522215424 available'], 'os': ['sdk-eng 2.3.7 GINGERBREAD eng.ubuntu.20140123.014351 test-keys'], 'id': ['52:54:00:12:34:56'], 'uptimemillis': ['148038'], 'temperature': ['Temperature: unknown']}
23:47:46     INFO -  Mochi-Remote INFO | Test root: /mnt/sdcard/tests
23:47:46     INFO -  Mochi-Remote INFO | Android sdk version '10'; will use this to filter manifests
23:47:46     INFO -  pk12util: PKCS12 IMPORT SUCCESSFUL
23:47:46     INFO -  MochitestServer : launching [u'/builds/slave/talos-slave/test/build/hostutils/bin/xpcshell', '-g', '/builds/slave/talos-slave/test/build/hostutils/xre', '-v', '170', '-f', '/builds/slave/talos-slave/test/build/hostutils/bin/components/httpd.js', '-e', "const _PROFILE_PATH = '/tmp/tmpifbcQP'; const _SERVER_PORT = '8854'; const _SERVER_ADDR = '10.0.2.2'; const _TEST_PREFIX = undefined; const _DISPLAY_RESULTS = false;", '-f', '/builds/slave/talos-slave/test/build/tests/mochitest/server.js']
23:47:46     INFO -  runtests.py | Server pid: 5574
23:47:46     INFO -  runtests.py | Websocket server pid: 5576
23:47:46     INFO -  INFO | runtests.py | SSL tunnel pid: 5578
23:47:46     INFO -  failed to bind socket
23:47:46     INFO -  Shutting down...
23:47:46     INFO -  uncaught exception: 2147746065
23:47:46  WARNING -  TEST-UNEXPECTED-FAIL | runtests.py | Timed out while waiting for server startup.
23:47:46     INFO -  Stopping web server
23:47:46     INFO -  Stopping web socket server
23:47:46     INFO -  Stopping ssltunnel
23:47:46     INFO -  Mochi-Remote ERROR | Automation Error: Exception caught while running tests
23:47:46     INFO -  Traceback (most recent call last):
23:47:46     INFO -    File "/builds/slave/talos-slave/test/build/tests/mochitest/runtestsremote.py", line 743, in main
23:47:46     INFO -      retVal = mochitest.runTests(options)
23:47:46     INFO -    File "/builds/slave/talos-slave/test/build/tests/mochitest/runtests.py", line 1374, in runTests
23:47:46     INFO -      self.startServers(options, debuggerInfo)
23:47:46     INFO -    File "/builds/slave/talos-slave/test/build/tests/mochitest/runtestsremote.py", line 337, in startServers
23:47:46     INFO -      Mochitest.startServers(self, options, debuggerInfo)
23:47:46     INFO -    File "/builds/slave/talos-slave/test/build/tests/mochitest/runtests.py", line 573, in startServers
23:47:46     INFO -      self.server.ensureReady(self.SERVER_STARTUP_TIMEOUT)
23:47:46     INFO -    File "/builds/slave/talos-slave/test/build/tests/mochitest/runtests.py", line 191, in ensureReady
23:47:46     INFO -      sys.exit(1)
23:47:46     INFO -  SystemExit: 1
23:47:46     INFO -  Stopping web server
23:47:46     INFO -  Stopping web socket server
23:47:46     INFO -  Stopping ssltunnel
23:47:46     INFO -  Mochi-Remote WARNING | Unable to retrieve log file (/mnt/sdcard/tests/logs/mochitest.log) from remote device
23:47:46     INFO -  Traceback (most recent call last):
23:47:46     INFO -    File "/builds/slave/talos-slave/test/build/tests/mochitest/runtestsremote.py", line 760, in <module>
23:47:46     INFO -      main()
23:47:46     INFO -    File "/builds/slave/talos-slave/test/build/tests/mochitest/runtestsremote.py", line 749, in main
23:47:46     INFO -      mochitest.cleanup(None, options)
23:47:46     INFO -    File "/builds/slave/talos-slave/test/build/tests/mochitest/runtestsremote.py", line 250, in cleanup
23:47:46     INFO -      Mochitest.cleanup(self, manifest, options)
23:47:46     INFO -    File "/builds/slave/talos-slave/test/build/tests/mochitest/runtests.py", line 1070, in cleanup
23:47:46     INFO -      os.remove(manifest)
23:47:46     INFO -  TypeError: coercing to Unicode: need string or buffer, NoneType found
23:47:46     INFO - TinderboxPrint: mochitest-gl<br/><em class="testfail">T-FAIL</em>

Comment 1

[Geoff Brown [:gbrown]]

Attachment: avoid cleanup if manifest not set

runtests.py and runtestsb2g.py already guard calls to cleanup() this way.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8433328 [details] [diff] [review]
avoid cleanup if manifest not set

Review of attachment 8433328 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mochitest/runtestsremote.py
@@ +246,5 @@
>          else:
>              log.warn("Unable to retrieve log file (%s) from remote device",
>                  self.remoteLog)
>          self._dm.removeDir(self.remoteProfile)
> +        if manifest is not None:

you could simplify this by doing:
if manifest:

Comment 3

[Geoff Brown [:gbrown]]

Thanks. I'll keep it consistent with runtests.py --

https://hg.mozilla.org/integration/mozilla-inbound/rev/c10a85fa06f0

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c10a85fa06f0