1019608 - More padding on the Resources landing

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Cassie McDaniel [:cassiemc]]

The yellow notification on the top of the landing page is a bit close to the headline and map graphic. I would add another 40-50px padding between the notification and the headline. Happy to review over vidyo if needed.

Comment 1

[Cassie McDaniel [:cassiemc]]

On second thought, I'm going to make this a general padding ticket, as there are a few padding issues on this page.

Have uploaded a redpen with comments to increase white space below the notification, between elements, above the bottom ctas, etc. See here: https://redpen.io/gj9b8cf570e3d6334d

If this is better as separate tickets, please feel free to break it up.

Comment 2

[Aki Rose Braun [:akirose]]

Attachment: https://github.com/mozilla/webmaker.org/pull/785

Comment 3

[Aki Rose Braun [:akirose]]

Attachment: https://www.dropbox.com/sh/kcrbog48orfz91y/AAC6YWZuWrkujONyghGiwUtZa

Screenshots of updated padding at multiple viewports. (Feel free to leave notes here, or we can do vidyo, or you can annotate in preview/skitch/photoshop/redpen and re-attach, whatever is easiest for you. This is just the easiest way for me to show you the changes made)

Comment 4

[Aki Rose Braun [:akirose]]

Attachment: https://redpen.io/p/kw86163d6863ac4f26

Updated these on redpen instead of dropbox.

Comment 5

[Cassie McDaniel [:cassiemc]]

Comment on attachment 8438104 [details]
https://redpen.io/p/kw86163d6863ac4f26

Left some comments on redpen, mostly on the mobile and larger desktop sizes

Comment 6

[Aki Rose Braun [:akirose]]

Comment on attachment 8438104 [details]
https://redpen.io/p/kw86163d6863ac4f26

Updated screen shots with those changes made

Comment 7

[Cassie McDaniel [:cassiemc]]

Comment on attachment 8438104 [details]
https://redpen.io/p/kw86163d6863ac4f26

Looks good :)

Comment 8

[inactivate account for kate]

Comment on attachment 8437268 [details] [review]
https://github.com/mozilla/webmaker.org/pull/785

Looks good, a couple of comments to address

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/b52525084a65660073106319aa91a8a0f5256590
Fix Bug 1019608 - More padding on the Resources landing

https://github.com/mozilla/webmaker.org/commit/dcec6d2ed3f737396f44dd72f8600708b92de55a
Merge pull request #785 from gesa/1019608/resources-padding

Bug 1019608 - More padding on the Resources landing