Closed
Bug 1019631
Opened 10 years ago
Closed 10 years ago
Convert device model names to lower case
Categories
(Testing Graveyard :: Eideticker, defect)
Testing Graveyard
Eideticker
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: davehunt, Assigned: davehunt)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.84 KB,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
The fix in bug 1007688 does not work against my Flame device because the model 'flame' does not match the model returned from ro.product.model, which is 'Flame' (title case). If this was a mistake in the original patch then we should fix it, however I suspect it may make sense to convert all model names to lowercase so we're not so sensitive.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8433348 -
Flags: review?(wlachance)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Missed one in last patch.
Attachment #8433348 -
Attachment is obsolete: true
Attachment #8433348 -
Flags: review?(wlachance)
Attachment #8433349 -
Flags: review?(wlachance)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8433349 [details] [diff] [review] Convert device model names to lower case. v1.1 This makes sense I guess.
Attachment #8433349 -
Flags: review?(wlachance) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Landed in: https://github.com/mozilla/eideticker/commit/b65776120e83e8dbcd8d62be54e792fb1dea7e8e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•