1019638 - Disabling DMD after enabling DMD doesn't stop DMD from running

Status: RESOLVED FIXED

(Core :: DMD, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

After getting a reboot loop when enabling DMD (see bug 1019634) on Flame, I decided to disable DMD and go back to a regular build. I removed the MOZ_DMD line from my userconfig and did a clean gecko build (rm -rf objdir-gecko && ./build.sh gecko && ./flash.sh gecko). However this didn't stop gecko from starting up with DMD enabled. I had to manually delete /system/b2g/libdmd.so from the phone to make it stop it's reboot loop. I think the flash script should delete libdmd.so if gecko was built without DMD.

Comment 1

[Eric Rahm [:erahm]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/B2G/pull/380

Comment 2

[Michael Wu [:mwu]]

Why is updater specifically not deleted?

Comment 3

[Eric Rahm [:erahm]]

(In reply to Michael Wu [:mwu] from comment #2)
> Why is updater specifically not deleted?

I wasn't sure what it was and it didn't seem to be building on my machine (I assume it came from the base image and shouldn't be removed), if it should be deleted I can remove the if.

Comment 4

[Michael Wu [:mwu]]

Comment on attachment 8477758 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/B2G/pull/380

I think this should be fine as long as we remove the special case for updater.

We can also simplify the command since we're not trying to delete a bunch of files at once -

run_adb shell "rm /system/b2g/$to_remove" > /dev/null

Comment 5

[Eric Rahm [:erahm]]

Comment on attachment 8477758 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/B2G/pull/380

PR has been updated with suggested changes.

Comment 6

[Eric Rahm [:erahm]]

https://github.com/mozilla-b2g/B2G/commit/c438ab6adf3dc517a703bed36791a64bbb693c83