Closed Bug 1019722 Opened 5 years ago Closed 5 years ago

Clang Static Analysis: Remove never read value to fix a minor warning found by scan-build. r=keeler

Categories

(Core :: Security, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: sblin, Assigned: sblin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1005652 +++

The attached patch fixes a warning detected by scan-build, the clang static analyzer.
Attached patch security-minor-fix.diff (obsolete) — Splinter Review
Attachment #8433446 - Flags: review?(kaie)
Attachment #8433446 - Flags: review?(dkeeler)
Comment on attachment 8433446 [details] [diff] [review]
security-minor-fix.diff

Review of attachment 8433446 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
My understanding is Kai isn't involved with PSM any more - I'm clearing this review so it doesn't nag him.
Attachment #8433446 - Flags: review?(kaie)
Attachment #8433446 - Flags: review?(dkeeler)
Attachment #8433446 - Flags: review+
Summary: Clang Static Analysis: Remove never read value to fix a minor warning found by scan-build. → Clang Static Analysis: Remove never read value to fix a minor warning found by scan-build. r=keeler
Attachment #8433520 - Flags: review+
Attachment #8433446 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/d63d139cec02
Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Blocks: 1031395
No longer blocks: 1031395
You need to log in before you can comment on or make changes to this bug.