Closed Bug 1019762 Opened 10 years ago Closed 10 years ago

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_gestureSupport.js | A promise chain failed to handle a rejection at chrome://global/content/bindings/browser.xml:310 - TypeError: this.docShell is null

Categories

(Firefox :: General, defect)

29 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 35

People

(Reporter: Yoric, Assigned: Yoric)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch mochi.gestureSplinter Review
08:01:40     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/base/content/test/general/browser_gestureSupport.js | Image rotation gesture end: expected=270, observed=270, init=0, amt=55, dir=ccl
08:01:41  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/general/browser_gestureSupport.js | A promise chain failed to handle a rejection at chrome://global/content/bindings/browser.xml:310 - TypeError: this.docShell is null
08:01:41     INFO -  Stack trace:
08:01:41     INFO -      get_webNavigation@chrome://global/content/bindings/browser.xml:310:13
08:01:41     INFO -  get_currentURI@chrome://global/content/bindings/browser.xml:205:1
08:01:41     INFO -  PageThumbs_captureAndStoreIfStale/<@resource://gre/modules/PageThumbs.jsm:301:1
08:01:41     INFO -  Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:863:11
08:01:41     INFO -  this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:742:7
Attachment #8433478 - Flags: review?(felipc)
Felipe, I still encounter the error.
Review ping?
re-ping? I'm seeing this in some other tests as well. I haven't investigated deeply yet, but I suspect my failures are from async window operations happening on different spins of the event loop depending on the exact order of events in my test.
Felipe, now that bug 1016387 is landing, we are seeing this creeping all over the place.
Urgent review needed.
Flags: needinfo?(felipc)
Comment on attachment 8433478 [details] [diff] [review]
mochi.gesture

Due to lack of review, requesting from other reviewers.
Attachment #8433478 - Flags: review?(gijskruitbosch+bugs)
Attachment #8433478 - Flags: review?(gijskruitbosch+bugs)
Attachment #8433478 - Flags: review?(felipc)
Attachment #8433478 - Flags: review?(bugs)
Attachment #8433478 - Flags: review+
Flags: needinfo?(felipc)
We had actually talked about this bug on IRC and fixed 2 other similar issues, but this one wasn't fully understood so we left it for more investigation. As this error is showing up in more places, and bug 1016387 is landing, we agreed to land it now to wallpaper and follow-up to investigate what's the cause for this and if there's something else that needs to be done.
Thanks for the reactivity, Felipe.
Filed followup bug 1081345.
https://hg.mozilla.org/mozilla-central/rev/e545c792a0bd
https://hg.mozilla.org/mozilla-central/rev/d06ee550656a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35
Assignee: nobody → dteller
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.