1019793 - java.lang.UnsupportedOperationException in TestHealthReportPruneService

Status: RESOLVED FIXED

(Android Background Services Graveyard :: Firefox Health Report Service, defect)

Description

[Nick Alexander :nalexander [he/him]]

This got busted by Bug 965371.  The MockContext() that the test uses is not with the new HardwareUtils code.  I'm not sure what the correct fix is here -- delete the test?  Use the target context?

I TestRunner(8149) started: testIsIntentValid(org.mozilla.gecko.background.healthreport.prune.TestHealthReportPruneService)
W GeckoHealth(8149) fennec_nalexander :: HealthReportPruneService :: Got intent without profileName.
W GeckoHealth(8149) fennec_nalexander :: HealthReportPruneService :: Got intent without profilePath.
W GeckoHealth(8149) fennec_nalexander :: HealthReportPruneService :: Intent not valid - returning.
W GeckoHealth(8149) fennec_nalexander :: HealthReportPruneService :: Got intent without profilePath.
W GeckoHealth(8149) fennec_nalexander :: HealthReportPruneService :: Intent not valid - returning.
W GeckoHealth(8149) fennec_nalexander :: HealthReportPruneService :: Got intent without profileName.
W GeckoHealth(8149) fennec_nalexander :: HealthReportPruneService :: Intent not valid - returning.
W dalvikvm(8149) threadid=12: thread exiting with uncaught exception (group=0x4191c898)
D AndroidRuntime(8134) Shutting down VM
D jdwp(8134) Got wake-up signal, bailing out of select
D dalvikvm(8134) Debugger has detached; object registry had 1 entries
E AndroidRuntime(8149) FATAL EXCEPTION: IntentService[HealthReportPruneServiceWorker]
E AndroidRuntime(8149) java.lang.UnsupportedOperationException
E AndroidRuntime(8149) at android.test.mock.MockContext.getResources(MockContext.java:66)
E AndroidRuntime(8149) at org.mozilla.gecko.background.healthreport.AndroidConfigurationProvider.<init>(AndroidConfigurationProvider.java:23)
E AndroidRuntime(8149) at org.mozilla.gecko.background.healthreport.prune.PrunePolicyDatabaseStorage.<init>(PrunePolicyDatabaseStorage.java:39)
E AndroidRuntime(8149) at org.mozilla.gecko.background.healthreport.prune.TestHealthReportPruneService$MockHealthReportPruneService.getPrunePolicy(TestHealthReportPruneService.java:45)
E AndroidRuntime(8149) at org.mozilla.gecko.background.healthreport.prune.HealthReportPruneService.onHandleIntent(HealthReportPruneService.java:52)
E AndroidRuntime(8149) at org.mozilla.gecko.background.healthreport.prune.TestHealthReportPruneService$MockHealthReportPruneService.onHandleIntent(TestHealthReportPruneService.java:28)
E AndroidRuntime(8149) at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:65)
E AndroidRuntime(8149) at android.os.Handler.dispatchMessage(Handler.java:99)
E AndroidRuntime(8149) at android.os.Looper.loop(Looper.java:137)
E AndroidRuntime(8149) at android.os.HandlerThread.run(HandlerThread.java:61)

Comment 1

[Richard Newman [:rnewman]]

Probably ought to rewire to use MockConfigurationProvider.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/461

Again, one PR, multiple small tickets.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8434463 [details] [review]
Link to Github pull-request: https://github.com/mozilla-services/android-sync/pull/461

Looks like this solves the problem, but I'm not sure what the extra commit does, as I commented on in Github.

Comment 4

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/857f771cf9ed

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/857f771cf9ed