1019851 - PROCESS-CRASH | /builds/slave/test/build/xpcshell/tests/mailnews/imap/test/unit/test_nsIMsgFolderListenerIMAP.js | application crashed [@ mozalloc_abort(char const*)]

Status: RESOLVED FIXED

(MailNews Core :: Testing Infrastructure, defect)

Description

[Joshua Cranmer [:jcranmer]]

Exact regression date unknown, as there's been no debug builds since Thursday.

Comment 1

[Kent James (:rkent)]

I agreed to look at these and other Windows test failures. Many of them show crashes which are possibly the same root cause.

Comment 2

[Kent James (:rkent)]

Attachment: 1019851.patch

These crashes are occurring because of a meaningless assert in nsImapMailFolder::GetFolderURL when called on a root folder. The odd thing is that the code is being called during do_check_neq(folder, null) while trying to stringify "folder" (which is NOT a root folder) so that it can print a debug error message, should it need to (which it does not need to). I have not idea why that generates a call to GetFolderURL for the root folder, the call stack is all xpcom code.

Any thoughts on just allowing the call as in this patch?

Comment 3

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=41034509&tree=Thunderbird-Trunk
TB Rev4 MacOSX Snow Leopard 10.6 comm-central debug test xpcshell on 2014-06-04 07:59:00
revision: babb5e26c4ed
slave: t-snow-r4-0011

TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/imap/test/unit/test_nsIMsgFolderListenerIMAP.js | test failed (with xpcshell return code: 1), see following log:
PROCESS-CRASH | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/imap/test/unit/test_nsIMsgFolderListenerIMAP.js | application crashed [@ mozalloc_abort(char const*)]
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure2.js | test failed (with xpcshell return code: 1), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/head.js | 2147500037 == 0 - See following stack:
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure2.js | 2147500036 - See following stack:
TEST-UNEXPECTED-FAIL | ../../../resources/logHelper.js | Error console says [stackFrame uncaught exception: 2147500036] - See following stack:
Assertion failure: !mAsyncExecutionThread (AsyncClose has not been invoked on this connection!), at /builds/slave/tb-c-cen-osx64-d-0000000000000/build/mozilla/storage/src/mozStorageConnection.cpp:491
PROCESS-CRASH | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure2.js | application crashed [@ mozilla::storage::Connection::~Connection()]
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure3.js | test failed (with xpcshell return code: 1), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/head.js | 2147500037 == 0 - See following stack:
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure3.js | 2147500036 - See following stack:
TEST-UNEXPECTED-FAIL | ../../../resources/logHelper.js | Error console says [stackFrame uncaught exception: 2147500036] - See following stack:
Assertion failure: !mAsyncExecutionThread (AsyncClose has not been invoked on this connection!), at /builds/slave/tb-c-cen-osx64-d-0000000000000/build/mozilla/storage/src/mozStorageConnection.cpp:491
PROCESS-CRASH | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure3.js | application crashed [@ mozilla::storage::Connection::~Connection()]
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/news/test/unit/test_nntpPasswordFailure.js | test failed (with xpcshell return code: 1), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/head.js | 0 == 2 - See following stack:
TEST-UNEXPECTED-FAIL | xpcshell/head.js | TypeError: ex.stack is undefined at ../../../resources/asyncTestUtils.js:169 - See following stack:
Assertion failure: !mAsyncExecutionThread (AsyncClose has not been invoked on this connection!), at /builds/slave/tb-c-cen-osx64-d-0000000000000/build/mozilla/storage/src/mozStorageConnection.cpp:491
PROCESS-CRASH | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/news/test/unit/test_nntpPasswordFailure.js | application crashed [@ mozilla::storage::Connection::~Connection()]

Comment 4

[Legacy TBPL/Treeherder Robot]

jcranmer
https://tbpl.mozilla.org/php/getParsedLog.php?id=41037161&tree=Thunderbird-Trunk
Ubuntu VM 12.04 comm-central debug test xpcshell on 2014-06-04 08:00:16
revision: babb5e26c4ed
slave: tst-linux32-ec2-031

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/mailnews/imap/test/unit/test_nsIMsgFolderListenerIMAP.js | test failed (with xpcshell return code: -11), see following log:
PROCESS-CRASH | /builds/slave/test/build/xpcshell/tests/mailnews/imap/test/unit/test_nsIMsgFolderListenerIMAP.js | application crashed [@ mozalloc_abort(char const*)]
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure2.js | test failed (with xpcshell return code: -11), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/head.js | 2147500037 == 0 - See following stack:
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure2.js | 2147500036 - See following stack:
TEST-UNEXPECTED-FAIL | ../../../resources/logHelper.js | Error console says [stackFrame uncaught exception: 2147500036] - See following stack:
Assertion failure: !mAsyncExecutionThread (AsyncClose has not been invoked on this connection!), at /builds/slave/tb-c-cen-lx-d-0000000000000000/build/mozilla/storage/src/mozStorageConnection.cpp:491
PROCESS-CRASH | /builds/slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure2.js | application crashed [@ mozilla::storage::Connection::~Connection()]
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure3.js | test failed (with xpcshell return code: -11), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/head.js | 2147500037 == 0 - See following stack:
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure3.js | 2147500036 - See following stack:
TEST-UNEXPECTED-FAIL | ../../../resources/logHelper.js | Error console says [stackFrame uncaught exception: 2147500036] - See following stack:
Assertion failure: !mAsyncExecutionThread (AsyncClose has not been invoked on this connection!), at /builds/slave/tb-c-cen-lx-d-0000000000000000/build/mozilla/storage/src/mozStorageConnection.cpp:491
PROCESS-CRASH | /builds/slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure3.js | application crashed [@ mozilla::storage::Connection::~Connection()]
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/mailnews/news/test/unit/test_nntpPasswordFailure.js | test failed (with xpcshell return code: -11), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/head.js | 0 == 2 - See following stack:
TEST-UNEXPECTED-FAIL | xpcshell/head.js | TypeError: ex.stack is undefined at ../../../resources/asyncTestUtils.js:169 - See following stack:
Assertion failure: !mAsyncExecutionThread (AsyncClose has not been invoked on this connection!), at /builds/slave/tb-c-cen-lx-d-0000000000000000/build/mozilla/storage/src/mozStorageConnection.cpp:491
PROCESS-CRASH | /builds/slave/test/build/xpcshell/tests/mailnews/news/test/unit/test_nntpPasswordFailure.js | application crashed [@ mozilla::storage::Connection::~Connection()]
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/uriloader/exthandler/tests/unit_ipc/test_encoding.js | test failed (with xpcshell return code: 0), see following log:
Only displaying first 20 of 21 failures -
.

Comment 5

[Legacy TBPL/Treeherder Robot]

jcranmer
https://tbpl.mozilla.org/php/getParsedLog.php?id=41037138&tree=Thunderbird-Trunk
TB Windows XP 32-bit comm-central debug test xpcshell on 2014-06-04 08:37:17
revision: babb5e26c4ed
slave: t-xp32-ix-035

TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\mail\base\test\unit\test_emptyTrash_dbViewWrapper.js | test failed (with xpcshell return code: -2147483645), see following log:
PROCESS-CRASH | C:\slave\test\build\xpcshell\tests\mail\base\test\unit\test_emptyTrash_dbViewWrapper.js | application crashed [@ mozalloc_abort(char const * const)]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\mailnews\imap\test\unit\test_offlinePlayback.js | test failed (with xpcshell return code: -2147483645), see following log:
PROCESS-CRASH | C:\slave\test\build\xpcshell\tests\mailnews\imap\test\unit\test_offlinePlayback.js | application crashed [@ mozalloc_abort(char const * const)]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\mailnews\imap\test\unit\test_copyThenMove.js | test failed (with xpcshell return code: -2147483645), see following log:
PROCESS-CRASH | C:\slave\test\build\xpcshell\tests\mailnews\imap\test\unit\test_copyThenMove.js | application crashed [@ mozalloc_abort(char const * const)]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\mailnews\imap\test\unit\test_imapAutoSync.js | test failed (with xpcshell return code: -2147483645), see following log:
PROCESS-CRASH | C:\slave\test\build\xpcshell\tests\mailnews\imap\test\unit\test_imapAutoSync.js | application crashed [@ mozalloc_abort(char const * const)]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\mailnews\imap\test\unit\test_gmailOfflineMsgStore.js | test failed (with xpcshell return code: -2147483645), see following log:
PROCESS-CRASH | C:\slave\test\build\xpcshell\tests\mailnews\imap\test\unit\test_gmailOfflineMsgStore.js | application crashed [@ mozalloc_abort(char const * const)]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\mailnews\imap\test\unit\test_imapFolderCopy.js | test failed (with xpcshell return code: -2147483645), see following log:
PROCESS-CRASH | C:\slave\test\build\xpcshell\tests\mailnews\imap\test\unit\test_imapFolderCopy.js | application crashed [@ mozalloc_abort(char const * const)]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\mailnews\imap\test\unit\test_nsIMsgFolderListenerIMAP.js | test failed (with xpcshell return code: -2147483645), see following log:
PROCESS-CRASH | C:\slave\test\build\xpcshell\tests\mailnews\imap\test\unit\test_nsIMsgFolderListenerIMAP.js | application crashed [@ mozalloc_abort(char const * const)]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\mailnews\imap\test\unit\test_imapStatusCloseDBs.js | test failed (with xpcshell return code: -2147483645), see following log:
PROCESS-CRASH | C:\slave\test\build\xpcshell\tests\mailnews\imap\test\unit\test_imapStatusCloseDBs.js | application crashed [@ mozalloc_abort(char const * const)]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\mailnews\imap\test\unit\test_imapUndo.js | test failed (with xpcshell return code: -2147483645), see following log:
PROCESS-CRASH | C:\slave\test\build\xpcshell\tests\mailnews\imap\test\unit\test_imapUndo.js | application crashed [@ mozalloc_abort(char const * const)]
TEST-UNEXPECTED-FAIL | C:\slave\test\build\xpcshell\tests\mailnews\local\test\unit\test_pop3PasswordFailure3.js | test failed (with xpcshell return code: -2147483645), see following log:
TEST-UNEXPECTED-FAIL | C:\\slave\\test\\build\\xpcshell\\head.js | 2147500037 == 0 - See following stack:
Only displaying first 20 of 37 failures -
.

Comment 6

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=41038797&tree=Thunderbird-Trunk
Ubuntu VM 12.04 x64 comm-central debug test xpcshell on 2014-06-04 08:17:54
revision: babb5e26c4ed
slave: tst-linux64-spot-722

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/mailnews/imap/test/unit/test_nsIMsgFolderListenerIMAP.js | test failed (with xpcshell return code: -11), see following log:
PROCESS-CRASH | /builds/slave/test/build/xpcshell/tests/mailnews/imap/test/unit/test_nsIMsgFolderListenerIMAP.js | application crashed [@ mozalloc_abort(char const*)]
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure2.js | test failed (with xpcshell return code: -11), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/head.js | 2147500037 == 0 - See following stack:
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure2.js | 2147500036 - See following stack:
TEST-UNEXPECTED-FAIL | ../../../resources/logHelper.js | Error console says [stackFrame uncaught exception: 2147500036] - See following stack:
Assertion failure: !mAsyncExecutionThread (AsyncClose has not been invoked on this connection!), at /builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/storage/src/mozStorageConnection.cpp:491
PROCESS-CRASH | /builds/slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure2.js | application crashed [@ mozilla::storage::Connection::~Connection()]
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure3.js | test failed (with xpcshell return code: -11), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/head.js | 2147500037 == 0 - See following stack:
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure3.js | 2147500036 - See following stack:
TEST-UNEXPECTED-FAIL | ../../../resources/logHelper.js | Error console says [stackFrame uncaught exception: 2147500036] - See following stack:
Assertion failure: !mAsyncExecutionThread (AsyncClose has not been invoked on this connection!), at /builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/storage/src/mozStorageConnection.cpp:491
PROCESS-CRASH | /builds/slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure3.js | application crashed [@ mozilla::storage::Connection::~Connection()]
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/mailnews/news/test/unit/test_nntpPasswordFailure.js | test failed (with xpcshell return code: -11), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/head.js | 0 == 2 - See following stack:
TEST-UNEXPECTED-FAIL | xpcshell/head.js | TypeError: ex.stack is undefined at ../../../resources/asyncTestUtils.js:169 - See following stack:
Assertion failure: !mAsyncExecutionThread (AsyncClose has not been invoked on this connection!), at /builds/slave/tb-c-cen-l64-d-000000000000000/build/mozilla/storage/src/mozStorageConnection.cpp:491
PROCESS-CRASH | /builds/slave/test/build/xpcshell/tests/mailnews/news/test/unit/test_nntpPasswordFailure.js | application crashed [@ mozilla::storage::Connection::~Connection()]
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/uriloader/exthandler/tests/unit_ipc/test_encoding.js | test failed (with xpcshell return code: 0), see following log:
Only displaying first 20 of 21 failures -
.

Comment 7

[Kent James (:rkent)]

At least one of these failures is also occurring in linux debug builds:

test_nsIMsgFolderListenerIMAP.js

I don't believe that the ASSERT here is meaningful. There is a reasonable response that can be given to a request for a folderURL for the root folder, and that is the URI of the root folder itself. As far as I can tell, this issue is coming up somehow in an attempt for javascript to stringify the XPCOM object as part of the test framework. I don't think it is worth trying to figure out why that is happening - but other opinions would be welcome.

See try run at https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=f4ae9b2e2189

Comment 8

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=41046476&tree=Thunderbird-Trunk
TB Rev5 MacOSX Mountain Lion 10.8 comm-central debug test xpcshell on 2014-06-04 10:55:30
revision: 2608fae8b13b
slave: talos-mtnlion-r5-056

TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/imap/test/unit/test_nsIMsgFolderListenerIMAP.js | test failed (with xpcshell return code: 1), see following log:
PROCESS-CRASH | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/imap/test/unit/test_nsIMsgFolderListenerIMAP.js | application crashed [@ mozalloc_abort(char const*)]
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure2.js | test failed (with xpcshell return code: 1), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/head.js | 2147500037 == 0 - See following stack:
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure2.js | 2147500036 - See following stack:
TEST-UNEXPECTED-FAIL | ../../../resources/logHelper.js | Error console says [stackFrame uncaught exception: 2147500036] - See following stack:
Assertion failure: !mAsyncExecutionThread (AsyncClose has not been invoked on this connection!), at /builds/slave/tb-c-cen-osx64-d-0000000000000/build/mozilla/storage/src/mozStorageConnection.cpp:491
PROCESS-CRASH | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure2.js | application crashed [@ mozilla::storage::Connection::~Connection()]
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure3.js | test failed (with xpcshell return code: 1), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/head.js | 2147500037 == 0 - See following stack:
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure3.js | 2147500036 - See following stack:
TEST-UNEXPECTED-FAIL | ../../../resources/logHelper.js | Error console says [stackFrame uncaught exception: 2147500036] - See following stack:
Assertion failure: !mAsyncExecutionThread (AsyncClose has not been invoked on this connection!), at /builds/slave/tb-c-cen-osx64-d-0000000000000/build/mozilla/storage/src/mozStorageConnection.cpp:491
PROCESS-CRASH | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/local/test/unit/test_pop3PasswordFailure3.js | application crashed [@ mozilla::storage::Connection::~Connection()]
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/news/test/unit/test_nntpPasswordFailure.js | test failed (with xpcshell return code: 1), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/talos-slave/test/build/xpcshell/head.js | 0 == 2 - See following stack:
TEST-UNEXPECTED-FAIL | xpcshell/head.js | TypeError: ex.stack is undefined at ../../../resources/asyncTestUtils.js:169 - See following stack:
Assertion failure: !mAsyncExecutionThread (AsyncClose has not been invoked on this connection!), at /builds/slave/tb-c-cen-osx64-d-0000000000000/build/mozilla/storage/src/mozStorageConnection.cpp:491
PROCESS-CRASH | /builds/slave/talos-slave/test/build/xpcshell/tests/mailnews/news/test/unit/test_nntpPasswordFailure.js | application crashed [@ mozilla::storage::Connection::~Connection()]

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 8433984 [details] [diff] [review]
1019851.patch

This feels reasonable to do, like you say, its a bit unclear what's happening, but I think this is safe enough.

Comment 10

[Kent James (:rkent)]

Checked in https://hg.mozilla.org/comm-central/rev/f7ab709f43b5