Closed
Bug 1019883
Opened 11 years ago
Closed 11 years ago
"expected" field of structured log messages should should not be populated for skipped tests
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla32
People
(Reporter: chmanchester, Assigned: chmanchester)
References
Details
Attachments
(1 file)
|
1.30 KB,
patch
|
jgraham
:
review+
|
Details | Diff | Splinter Review |
mozlog.structured populates the 'expected' field of log messages in cases status != expected, including when the test status is 'SKIP' and the expected is 'PASS'.
This convention appears to be used to determining when a test is considered a failure by the test run, which arguably not the case for skipped tests. Either we can stop depending on this convention, or not populate the field for 'SKIP' tests. I will post a patch doing the latter.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8433586 -
Flags: review?(james)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → cmanchester
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8433586 [details] [diff] [review]
Don't populate expected field in log messages for skipped tests.;
Review of attachment 8433586 [details] [diff] [review]:
-----------------------------------------------------------------
Yes, I think this makes sense.
Attachment #8433586 -
Flags: review?(james) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
Keywords: checkin-needed
|
|
||
Comment 4•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•