"expected" field of structured log messages should should not be populated for skipped tests

RESOLVED FIXED in mozilla32

Status

Testing
Mozbase
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: chmanchester, Assigned: chmanchester)

Tracking

unspecified
mozilla32
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
mozlog.structured populates the 'expected' field of log messages in cases status != expected, including when the test status is 'SKIP' and the expected is 'PASS'. 

This convention appears to be used to determining when a test is considered a failure by the test run, which arguably not the case for skipped tests. Either we can stop depending on this convention, or not populate the field for 'SKIP' tests. I will post a patch doing the latter.
(Assignee)

Comment 1

4 years ago
Created attachment 8433586 [details] [diff] [review]
Don't populate expected field in log messages for skipped tests.;
Attachment #8433586 - Flags: review?(james)
(Assignee)

Updated

4 years ago
Assignee: nobody → cmanchester
(Assignee)

Updated

4 years ago
Blocks: 956739
Comment on attachment 8433586 [details] [diff] [review]
Don't populate expected field in log messages for skipped tests.;

Review of attachment 8433586 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, I think this makes sense.
Attachment #8433586 - Flags: review?(james) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c19d5dcd5759
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.