1019894 - [Vertical Homescreen] Migrate test_homescreen_launch_app.py and test_homescreen_delete_app.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P1)

Description

[Johan Lorenzo [:jlorenzo]]

We need to migrate test_homescreen_launch_app.py to be running on the new Vertical Homescreen.

See Bug 1019891 for patch proposal instructions.

Comment 2

[Zac C (:zac)]

These two tests are very similar so can be done at once.

Comment 3

[Zac C (:zac)]

Attachment: git commit

This migrates *only* the methods used by test_delete and test_install

Rebuild your python env before you r? it.

It will have to be merged inconjunction with all the other tests, but we can pre-prepare the commits.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8434998 [details]
git commit

LGTM. Both tests work on my Flame. I left one minor question about the name of the app.

Another question: Is it an issue if we cannot see the marionette deleting the icon because the icon is off-screen?

Comment 5

[Zac C (:zac)]

(In reply to Johan Lorenzo [:jlorenzo] from comment #4)
> Comment on attachment 8434998 [details]
> git commit
> 
> LGTM. Both tests work on my Flame. I left one minor question about the name
> of the app.
> 
> Another question: Is it an issue if we cannot see the marionette deleting
> the icon because the icon is off-screen?

Yes but the manifest name is "Vertical" !
https://github.com/mozilla-b2g/gaia/blob/master/apps/verticalhome/manifest.webapp#L2

The delete is robust because it checks the item is not present at all rather than just not displayed.

Comment 6

[Viorela Ioia [:viorela]]

Comment on attachment 8434998 [details]
git commit

lgtm, tests are running really nice! :)

Comment 7

[Zac C (:zac)]

Fixed in:
https://github.com/mozilla-b2g/gaia/commit/4b879aaba35607fa7e919e97cd99ba798a023d47