Closed Bug 1019897 Opened 9 years ago Closed 9 years ago

[Vertical Homescreen] Migrate test_homescreen_move_app.py and test_homescreen_edit_app.py

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jlorenzo, Assigned: zcampbell)

References

Details

User Story

We need to create test_verticalhome_launch_app.py from test_homescreen_launch_app.py to be running on the new Vertical Homescreen.

See Bug ... for patch proposal.

Attachments

(1 file, 2 obsolete files)

76 bytes, text/plain
Bebe
: feedback+
jlorenzo
: feedback+
Details
We need to migrate test_homescreen_move_app.py to be running on the new Vertical Homescreen.

See Bug 1019891 for patch proposal instructions.
Assignee: nobody → zcampbell
Depends on: 1020896
These two tests have a lot in common so they can be done at the same time.
Summary: [Vertical Homescreen] Migrate test_homescreen_move_app.py → [Vertical Homescreen] Migrate test_homescreen_move_app.py and test_homescreen_edit_app.py
Attached file git commit (obsolete) —
This will fail because of the blocking bug, but let's f? it anyway so we can prepare all the commits to be landed at the same time.
Attachment #8435000 - Flags: feedback?(viorela.ioia)
Attachment #8435000 - Flags: feedback?(jlorenzo)
Comment on attachment 8435000 [details]
git commit

test_hs_move_app.py is failing on my Flame even with bypassing the home button issue. Stacktrace: https://pastebin.mozilla.org/5354985

It seems to be a DOM problem. The DOM order is not updated after moving an app.
Attachment #8435000 - Flags: feedback?(jlorenzo) → feedback-
Blocks: 1019900
Blocks: 1021098
Comment on attachment 8435000 [details]
git commit

test_homescreen_move_app.py is failing with the error Johan described above. Also, I left a comment in the PR
Attachment #8435000 - Flags: feedback?(viorela.ioia) → feedback-
Attached file git commit (obsolete) —
The test will still fail at `touch_home_button` but now it can interpret the order of the apps correctly.
Attachment #8435778 - Flags: feedback?(viorela.ioia)
Attachment #8435778 - Flags: feedback?(jlorenzo)
Attached file git commit
Still failing at touch home, but knows the order properly now.
Attachment #8435000 - Attachment is obsolete: true
Attachment #8435778 - Attachment is obsolete: true
Attachment #8435778 - Flags: feedback?(viorela.ioia)
Attachment #8435778 - Flags: feedback?(jlorenzo)
Attachment #8435786 - Flags: feedback?(jlorenzo)
Attachment #8435786 - Flags: feedback?(florin.strugariu)
Comment on attachment 8435786 [details]
git commit

The code looks OK but the commit fails when ran on device
Attachment #8435786 - Flags: feedback?(florin.strugariu) → feedback-
Attachment #8435786 - Flags: feedback- → feedback+
Comment on attachment 8435786 [details]
git commit

LGTM. Just Homescreen's hardcoded string that we can avoid. Comments are in that PR: https://github.com/mozilla-b2g/gaia/pull/20148
Attachment #8435786 - Flags: feedback?(jlorenzo) → feedback+
Fixed:
https://github.com/mozilla-b2g/gaia/commit/eb9a992da11ca09e65a7ddba06c01badcf4641a6
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.