messenger.properties should use string based identifiers rather than numbers

RESOLVED FIXED in Thunderbird 47.0

Status

MailNews Core
Networking
--
trivial
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 47.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

7.86 KB, patch
aceman
: review+
Details | Diff | Splinter Review
(Assignee)

Description

4 years ago
There are some remaining numeric string identifiers in messenger.properties. This makes it harder for localisers to work with, and means that if we need to tweak strings then it isn't easy to change the string identifier to notify the localisers.

We should work on replacing the numbers with strings.
This bug serves the same purpose as bug #858238 and bug #551919.
(Assignee)

Comment 1

4 years ago
Created attachment 8433622 [details] [diff] [review]
patch
Attachment #8433622 - Flags: review?(neil)

Comment 2

4 years ago
Comment on attachment 8433622 [details] [diff] [review]
patch

We never fetch the "Unknown Error" message, so you should remove it from the properties file and use nullptr as the sentinel value instead (which allows you to do a pointer compare).
Attachment #8433622 - Flags: review?(neil) → review-
(Assignee)

Comment 3

4 years ago
Created attachment 8436072 [details] [diff] [review]
patch v2

OK.
Attachment #8433622 - Attachment is obsolete: true
Attachment #8436072 - Flags: review?(neil)

Comment 4

4 years ago
Comment on attachment 8436072 [details] [diff] [review]
patch v2

(I wonder why I didn't bikeshed about the naming of errorString or whether FormatStringWIthHotNameByName should be a private static class method.)
Attachment #8436072 - Flags: review?(neil) → review+
(Assignee)

Comment 5

2 years ago
I wonder why this never landed. Let's check if it still applies ;)
(Assignee)

Comment 6

2 years ago
Created attachment 8720986 [details] [diff] [review]
patch v2.1

Updated to current trunk.
Attachment #8436072 - Attachment is obsolete: true
Attachment #8720986 - Flags: review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 7

2 years ago
https://hg.mozilla.org/comm-central/rev/2c5cd6504ce2
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 47.0
You need to log in before you can comment on or make changes to this bug.