appleMailImportMsgs.properties should use string based identifiers rather than numbers

RESOLVED FIXED in Thunderbird 32.0

Status

MailNews Core
Import
--
trivial
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: aceman, Assigned: aceman)

Tracking

Trunk
Thunderbird 32.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
appleMailImportMsgs.properties currently uses numbers for its identifiers rather than strings. This makes it harder for localisers to work with, and means that if we need to tweak strings then it isn't easy to change the string identifier to notify the localisers.

We should work on replacing the numbers with strings.
This bug serves the same purpose as bug #858238 and bug #551919.
(Assignee)

Comment 1

3 years ago
Created attachment 8433641 [details] [diff] [review]
1019945.patch

I couldn't compile test this on Linux. Can anybody please push this to try server? OS X platform only is enough. Thanks.
Flags: needinfo?(syshagarwal)
Flags: needinfo?(archaeopteryx)
Pushed to Thunderbird-Try as https://tbpl.mozilla.org/?tree=Thunderbird-Try&showall=1&rev=7bcff6a30f7d
Flags: needinfo?(syshagarwal)
Flags: needinfo?(archaeopteryx)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8433641 [details] [diff] [review]
1019945.patch

Thanks, seems to build fine.
Attachment #8433641 - Flags: review?(standard8)
Comment on attachment 8433641 [details] [diff] [review]
1019945.patch

Review of attachment 8433641 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=Standard8
Attachment #8433641 - Flags: review?(standard8) → review+
(Assignee)

Comment 5

3 years ago
Thanks.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/f6c069c7563c
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 32.0
You need to log in before you can comment on or make changes to this bug.