Closed
Bug 1019945
Opened 10 years ago
Closed 10 years ago
appleMailImportMsgs.properties should use string based identifiers rather than numbers
Categories
(MailNews Core :: Import, defect)
MailNews Core
Import
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 32.0
People
(Reporter: aceman, Assigned: aceman)
Details
Attachments
(1 file)
11.81 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
appleMailImportMsgs.properties currently uses numbers for its identifiers rather than strings. This makes it harder for localisers to work with, and means that if we need to tweak strings then it isn't easy to change the string identifier to notify the localisers. We should work on replacing the numbers with strings. This bug serves the same purpose as bug #858238 and bug #551919.
I couldn't compile test this on Linux. Can anybody please push this to try server? OS X platform only is enough. Thanks.
Flags: needinfo?(syshagarwal)
Flags: needinfo?(archaeopteryx)
Comment 2•10 years ago
|
||
Pushed to Thunderbird-Try as https://tbpl.mozilla.org/?tree=Thunderbird-Try&showall=1&rev=7bcff6a30f7d
Flags: needinfo?(syshagarwal)
Flags: needinfo?(archaeopteryx)
Comment on attachment 8433641 [details] [diff] [review] 1019945.patch Thanks, seems to build fine.
Attachment #8433641 -
Flags: review?(standard8)
Comment 4•10 years ago
|
||
Comment on attachment 8433641 [details] [diff] [review] 1019945.patch Review of attachment 8433641 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, r=Standard8
Attachment #8433641 -
Flags: review?(standard8) → review+
Comment 6•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/f6c069c7563c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 32.0
You need to log in
before you can comment on or make changes to this bug.
Description
•