Closed Bug 1019967 Opened 10 years ago Closed 10 years ago

[ringtones] I broke pausing the music app during the share ringtone activity

Categories

(Firefox OS Graveyard :: Gaia::Ringtones, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Ringtones
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: squib, Unassigned)

Details

(Keywords: regression)

Attachments

(1 file)

Fix it
46 bytes, text/x-github-pull-request
djf
: review+
Details | Review
Attached file Fix it — 
See the bug title; if you hit play in the "ringtone share" activity while music is playing, we don't pause the music because I broke that. So let's fix it.
Attachment #8433664 - Flags: review?(dflanagan)
Comment on attachment 8433664 [details] [review]
Fix it

One nit on github that I'd like you to fix before landing. 

I like the no-nonsense bug description here :-)
Attachment #8433664 - Flags: review?(dflanagan) → review+
Landed: https://github.com/mozilla-b2g/gaia/commit/243587bf1207f8ab06b0471405ddb92a86170c40

Tests for this are being tracked in bug 984260.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: