[Keyboard] Correct compositekey to compositeKey

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: raniere, Assigned: raniere)

Tracking

unspecified
x86_64
Linux

Firefox Tracking Flags

(b2g-v2.1 fixed)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
rudyl
: review+
Details | Review | Splinter Review
(Assignee)

Description

4 years ago
Only requesting to replace compositekey by compositeKey to follow interCaps style.
(Assignee)

Updated

4 years ago
Summary: [Keyboard] Correct compositekey as well to compositeKey → [Keyboard] Correct compositekey to compositeKey
(Assignee)

Comment 1

4 years ago
Created attachment 8433716 [details] [review]
patch

I believe this is what Rudy suggested at https://github.com/mozilla-b2g/gaia/pull/19334#discussion_r13318118.
Attachment #8433716 - Flags: review?(rlu)
(Assignee)

Updated

4 years ago
Blocks: 1011661
Comment on attachment 8433716 [details] [review]
patch

Looks good to me, thanks.

Please help take care of the Travis CI before landing.
Attachment #8433716 - Flags: review?(rlu) → review+
Assignee: nobody → ra092767
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 3

4 years ago
Rudy, green light from Travis CI.
Flags: needinfo?(rlu)
Thanks.

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/266fa64fabe8340c1b361dcd52b758116811fbf8
status-b2g-v2.1: --- → fixed
Flags: needinfo?(rlu)
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Hi Raniere,

Could you please provide the detailed reproduce steps or video for me to verify this bug?
Thank you very much!
Flags: needinfo?(ra092767)
(Assignee)

Comment 6

4 years ago
Lancy,

Sorry but I didn't understand your request.
Flags: needinfo?(ra092767) → needinfo?(yulan.zhu)
Raniere,

Need QA verify this issue? 
According to the title, I didn't understand the issue, so I need your help to provide detailed information.
Flags: needinfo?(yulan.zhu) → needinfo?(ra092767)
(Assignee)

Comment 8

4 years ago
Lancy,

sorry for the delay.

> Need QA verify this issue?

I don't think so.

> According to the title, I didn't understand the issue, so I need your help to provide detailed information.

Mozilla's code style suggest use camelCase for some variables. I suggested to replace compositekey with compositeKey for the keyboard app.
Flags: needinfo?(ra092767)
You need to log in before you can comment on or make changes to this bug.