Only requesting to replace compositekey by compositeKey to follow interCaps style.
Summary: [Keyboard] Correct compositekey as well to compositeKey → [Keyboard] Correct compositekey to compositeKey
I believe this is what Rudy suggested at https://github.com/mozilla-b2g/gaia/pull/19334#discussion_r13318118.
Attachment #8433716 - Flags: review?(rlu)
Comment on attachment 8433716 [details] [review] patch Looks good to me, thanks. Please help take care of the Travis CI before landing.
Attachment #8433716 - Flags: review?(rlu) → review+
Assignee: nobody → ra092767
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Rudy, green light from Travis CI.
Thanks. Landed to Gaia master, https://github.com/mozilla-b2g/gaia/commit/266fa64fabe8340c1b361dcd52b758116811fbf8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Hi Raniere, Could you please provide the detailed reproduce steps or video for me to verify this bug? Thank you very much!
Lancy, Sorry but I didn't understand your request.
Flags: needinfo?(ra092767) → needinfo?(yulan.zhu)
Raniere, Need QA verify this issue? According to the title, I didn't understand the issue, so I need your help to provide detailed information.
Flags: needinfo?(yulan.zhu) → needinfo?(ra092767)
Lancy, sorry for the delay. > Need QA verify this issue? I don't think so. > According to the title, I didn't understand the issue, so I need your help to provide detailed information. Mozilla's code style suggest use camelCase for some variables. I suggested to replace compositekey with compositeKey for the keyboard app.
You need to log in before you can comment on or make changes to this bug.