102004 - need to move nsCharsetMenu into xpfe

Status: RESOLVED FIXED

(Core :: Internationalization, defect, P2)

Description

[Alec Flett]

In order for embeddors to be able to use the i18n libraries, we need to break
it's dependency on rdf. The only thing that's actually making use of rdf is the
charset data source, which provides the backend to the "View->Character Coding"
menu in the browser. This is a front-end feature that should be moved into xpfe
somewhere. I'm thinking I'm going to create a new directory under xpfe and just
put this in the appcomps module.

CC'ing appropriate i18n folks, and an xpfe person so that they know what I'm
dumping in their directories.

Comment 1

[Alec Flett]

Attachment: patch with win32 makefile changes

Comment 2

[Alec Flett]

I'll attach unix makefiles as soon as I can...
can I get an r=/sr= on these patches? When I have unix and windows covered, I'll
need a mac guy to help me land..

Comment 3

[Alec Flett]

argh, one minor tweak to that patch is to remove the #include "rdf.h" from
nsUConvModule.cpp

Also, the two files, nsCharsetMenu.cpp and nsCharsetMenu.h are just direct
copies of the originals in intl/uconv/src, with the addition of
NS_NewCharsetMenu copied over from nsUConvDll.h

Comment 4

[Alec Flett]

see also bug 102085 for similar stuff with font package handling

Comment 5

[[e-mail] (away - not reading bugmail)]

alecf: cata is gone. I'm cc'ing ftang as he would have to sign off on any 
changes to i18n modules. I'd be happy to help with the review after he agrees 
with the change.

Comment 6

[Alec Flett]

Attachment: updated patch, including mac, win32, and unix makefile changes

Comment 7

[Alec Flett]

see also attachment 51330 [details] [diff] [review] in bug 102085, which adds the new files to the build
the new files have been checked in, and are not yet part of the build.
They are in 
http://lxr.mozilla.org/seamonkey/source/xpfe/components/intl/

Comment 8

[Frank Tang]

Comment on attachment 51310 [details] [diff] [review]
updated patch, including mac, win32, and unix makefile changes

r=ftang

Comment 9

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 51310 [details] [diff] [review]
updated patch, including mac, win32, and unix makefile changes

sr=shaver

Comment 10

[Alec Flett]

cool, everything has landed.

Comment 11

[Yuying Long]

Frank, could you or some other one verify this? cause seems it a code change issue.