need to move nsCharsetMenu into xpfe

RESOLVED FIXED in mozilla0.9.5

Status

()

Core
Internationalization
P2
normal
RESOLVED FIXED
17 years ago
17 years ago

People

(Reporter: Alec Flett, Assigned: Alec Flett)

Tracking

({intl})

Trunk
mozilla0.9.5
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fix in hand)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

17 years ago
In order for embeddors to be able to use the i18n libraries, we need to break
it's dependency on rdf. The only thing that's actually making use of rdf is the
charset data source, which provides the backend to the "View->Character Coding"
menu in the browser. This is a front-end feature that should be moved into xpfe
somewhere. I'm thinking I'm going to create a new directory under xpfe and just
put this in the appcomps module.

CC'ing appropriate i18n folks, and an xpfe person so that they know what I'm
dumping in their directories.
(Assignee)

Updated

17 years ago
Blocks: 100107
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla0.9.5
(Assignee)

Comment 1

17 years ago
Created attachment 51143 [details] [diff] [review]
patch with win32 makefile changes
(Assignee)

Comment 2

17 years ago
I'll attach unix makefiles as soon as I can...
can I get an r=/sr= on these patches? When I have unix and windows covered, I'll
need a mac guy to help me land..
(Assignee)

Comment 3

17 years ago
argh, one minor tweak to that patch is to remove the #include "rdf.h" from
nsUConvModule.cpp

Also, the two files, nsCharsetMenu.cpp and nsCharsetMenu.h are just direct
copies of the originals in intl/uconv/src, with the addition of
NS_NewCharsetMenu copied over from nsUConvDll.h
(Assignee)

Comment 4

17 years ago
see also bug 102085 for similar stuff with font package handling
alecf: cata is gone. I'm cc'ing ftang as he would have to sign off on any 
changes to i18n modules. I'd be happy to help with the review after he agrees 
with the change.

Updated

17 years ago
Keywords: intl
QA Contact: andreasb → ylong
(Assignee)

Comment 6

17 years ago
Created attachment 51310 [details] [diff] [review]
updated patch, including mac, win32, and unix makefile changes
(Assignee)

Updated

17 years ago
Attachment #51143 - Attachment is obsolete: true
(Assignee)

Updated

17 years ago
Whiteboard: fix in hand
(Assignee)

Comment 7

17 years ago
see also attachment 51330 [details] [diff] [review] in bug 102085, which adds the new files to the build
the new files have been checked in, and are not yet part of the build.
They are in 
http://lxr.mozilla.org/seamonkey/source/xpfe/components/intl/

Comment 8

17 years ago
Comment on attachment 51310 [details] [diff] [review]
updated patch, including mac, win32, and unix makefile changes

r=ftang
Attachment #51310 - Flags: review+
Comment on attachment 51310 [details] [diff] [review]
updated patch, including mac, win32, and unix makefile changes

sr=shaver
Attachment #51310 - Flags: superreview+
(Assignee)

Comment 10

17 years ago
cool, everything has landed.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 11

17 years ago
Frank, could you or some other one verify this? cause seems it a code change issue.
QA Contact: ylong → ftang
You need to log in before you can comment on or make changes to this bug.