1020045 - (apz-overscroll) [meta] Enable APZ overscroll effect

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Tracking bug

Comment 1

[Botond Ballo [:botond]]

Attachment: Turn on overscrolling by default (Gecko part)

As per our discussion with Milan this morning, we are turning on overscrolling by default. Note: bug 1018255 will land together with this; the other dependencies should be fixed in the coming days.

Comment 2

[Botond Ballo [:botond]]

Attachment: Turn on overscrolling by default (Gaia part)

Comment 3

[Botond Ballo [:botond]]

Combined Try push for bug 1018255 and this bug: https://tbpl.mozilla.org/?tree=Try&rev=d88bfc86e7f5

Comment 4

[Botond Ballo [:botond]]

(P.S. Yay for only having to change the pref value in 4 places ;-)).

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8435857 [details] [diff] [review]
Turn on overscrolling by default (Gecko part)

Review of attachment 8435857 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxPrefs.h
@@ +120,5 @@
>    DECL_GFX_PREF(Once, "apz.max_velocity_inches_per_ms",        APZMaxVelocity, float, -1.0f);
>    DECL_GFX_PREF(Once, "apz.max_velocity_queue_size",           APZMaxVelocityQueueSize, uint32_t, 5);
>    DECL_GFX_PREF(Live, "apz.min_skate_speed",                   APZMinSkateSpeed, float, 1.0f);
>    DECL_GFX_PREF(Live, "apz.num_paint_duration_samples",        APZNumPaintDurationSamples, int32_t, 3);
> +  DECL_GFX_PREF(Live, "apz.overscroll.enabled",                APZOverscrollEnabled, bool, true);

Leave this one as false. The b2g.js overrides this, and we don't want it enabled on metro, if that's still a thing.

Comment 6

[Botond Ballo [:botond]]

Attachment: Turn on overscrolling by default (Gecko part)

Updated to address review comment. Carrying r+.

Comment 7

[Botond Ballo [:botond]]

The tree closed before I could land this, but it is ready to land.

Comment 8

[Botond Ballo [:botond]]

Tree is open, landed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/78c20dbe259e

Comment 9

[Botond Ballo [:botond]]

PR for Gaia patch:

https://github.com/mozilla-b2g/gaia/pull/20161

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/78c20dbe259e

Comment 11

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/theres-waldo/gaia/commit/2c15ecb0265290314dd9272a0056bba79bdf6f8b

Comment 12

[Kartikaya Gupta (email:[e-mail])]

(Gaia repo URL is https://github.com/mozilla-b2g/gaia/commit/2766e53ec6d4e268128adac6066345f18dcd871b)

Comment 14

[Kartikaya Gupta (email:[e-mail])]

We should look through the dependency list for this bug and ensure any important fixes are uplifted to 2.0.

Comment 15

[Botond Ballo [:botond]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #14)
> We should look through the dependency list for this bug and ensure any
> important fixes are uplifted to 2.0.

The following dependencies are not fixed in 2.0:

 - bug 1035598
 - bug 1036119
 - bgu 1037191

(I'm not counting bug 1031024 which is test-only code.)

I think it would be good to uplift bug 1035598 and bug 1036119, although their fixes are not super-low-risk as they make changes to AsyncCompositionManager.

For bug 1037191, see https://bugzilla.mozilla.org/show_bug.cgi?id=1037191#c8.

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Ok, please request uplift on the bugs that you think should be uplifted. If you're not sure then request uplift anyway and let the release drivers decide.

Comment 17

[Kartikaya Gupta (email:[e-mail])]

This was disabled in 2.0 in bug 1064401.