Closed Bug 1020045 (apz-overscroll) Opened 9 years ago Closed 9 years ago

[meta] Enable APZ overscroll effect

Categories

(Core :: Panning and Zooming, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32
Tracking Status
b2g-v2.0 --- disabled
b2g-v2.0M --- disabled

People

(Reporter: kats, Assigned: botond)

References

Details

(Keywords: meta)

Attachments

(2 files, 1 obsolete file)

Attached patch Turn on overscrolling by default (Gecko part) (obsolete) — — Splinter Review
As per our discussion with Milan this morning, we are turning on overscrolling by default. Note: bug 1018255 will land together with this; the other dependencies should be fixed in the coming days.
Assignee: nobody → botond
Attachment #8435857 - Flags: review?(bugmail.mozilla)
Attachment #8435860 - Flags: review?(bugmail.mozilla)
Combined Try push for bug 1018255 and this bug: https://tbpl.mozilla.org/?tree=Try&rev=d88bfc86e7f5
(P.S. Yay for only having to change the pref value in 4 places ;-)).
Comment on attachment 8435857 [details] [diff] [review]
Turn on overscrolling by default (Gecko part)

Review of attachment 8435857 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxPrefs.h
@@ +120,5 @@
>    DECL_GFX_PREF(Once, "apz.max_velocity_inches_per_ms",        APZMaxVelocity, float, -1.0f);
>    DECL_GFX_PREF(Once, "apz.max_velocity_queue_size",           APZMaxVelocityQueueSize, uint32_t, 5);
>    DECL_GFX_PREF(Live, "apz.min_skate_speed",                   APZMinSkateSpeed, float, 1.0f);
>    DECL_GFX_PREF(Live, "apz.num_paint_duration_samples",        APZNumPaintDurationSamples, int32_t, 3);
> +  DECL_GFX_PREF(Live, "apz.overscroll.enabled",                APZOverscrollEnabled, bool, true);

Leave this one as false. The b2g.js overrides this, and we don't want it enabled on metro, if that's still a thing.
Attachment #8435857 - Flags: review?(bugmail.mozilla) → review+
Attachment #8435860 - Flags: review?(bugmail.mozilla) → review+
Updated to address review comment. Carrying r+.
Attachment #8435857 - Attachment is obsolete: true
Attachment #8435980 - Flags: review+
Attachment #8435980 - Flags: checkin+
The tree closed before I could land this, but it is ready to land.
Keywords: checkin-needed
PR for Gaia patch:

https://github.com/mozilla-b2g/gaia/pull/20161
https://hg.mozilla.org/mozilla-central/rev/78c20dbe259e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Depends on: 1023473
Depends on: 1025436
Depends on: 1026793
Depends on: 1027633
Depends on: 1023506
Depends on: 1030429
Depends on: 1031067
No longer depends on: 1034376
Depends on: 1036119
Depends on: 1037180
Depends on: 1037191
We should look through the dependency list for this bug and ensure any important fixes are uplifted to 2.0.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #14)
> We should look through the dependency list for this bug and ensure any
> important fixes are uplifted to 2.0.

The following dependencies are not fixed in 2.0:

 - bug 1035598
 - bug 1036119
 - bgu 1037191

(I'm not counting bug 1031024 which is test-only code.)

I think it would be good to uplift bug 1035598 and bug 1036119, although their fixes are not super-low-risk as they make changes to AsyncCompositionManager.

For bug 1037191, see https://bugzilla.mozilla.org/show_bug.cgi?id=1037191#c8.
Ok, please request uplift on the bugs that you think should be uplifted. If you're not sure then request uplift anyway and let the release drivers decide.
Depends on: 1046013
This was disabled in 2.0 in bug 1064401.
See Also: → 1064401
Depends on: 1073618
You need to log in before you can comment on or make changes to this bug.