Bug 1020045 (apz-overscroll)

[meta] Enable APZ overscroll effect

RESOLVED FIXED in mozilla32



5 years ago
4 years ago


(Reporter: kats, Assigned: botond)



Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.0 disabled, b2g-v2.0M disabled)



(2 attachments, 1 obsolete attachment)

Tracking bug
Keywords: meta
Created attachment 8435857 [details] [diff] [review]
Turn on overscrolling by default (Gecko part)

As per our discussion with Milan this morning, we are turning on overscrolling by default. Note: bug 1018255 will land together with this; the other dependencies should be fixed in the coming days.
Assignee: nobody → botond
Attachment #8435857 - Flags: review?(bugmail.mozilla)
Created attachment 8435860 [details] [diff] [review]
Turn on overscrolling by default (Gaia part)
Attachment #8435860 - Flags: review?(bugmail.mozilla)
(P.S. Yay for only having to change the pref value in 4 places ;-)).
Comment on attachment 8435857 [details] [diff] [review]
Turn on overscrolling by default (Gecko part)

Review of attachment 8435857 [details] [diff] [review]:

::: gfx/thebes/gfxPrefs.h
@@ +120,5 @@
>    DECL_GFX_PREF(Once, "apz.max_velocity_inches_per_ms",        APZMaxVelocity, float, -1.0f);
>    DECL_GFX_PREF(Once, "apz.max_velocity_queue_size",           APZMaxVelocityQueueSize, uint32_t, 5);
>    DECL_GFX_PREF(Live, "apz.min_skate_speed",                   APZMinSkateSpeed, float, 1.0f);
>    DECL_GFX_PREF(Live, "apz.num_paint_duration_samples",        APZNumPaintDurationSamples, int32_t, 3);
> +  DECL_GFX_PREF(Live, "apz.overscroll.enabled",                APZOverscrollEnabled, bool, true);

Leave this one as false. The b2g.js overrides this, and we don't want it enabled on metro, if that's still a thing.
Attachment #8435857 - Flags: review?(bugmail.mozilla) → review+
Attachment #8435860 - Flags: review?(bugmail.mozilla) → review+
Created attachment 8435980 [details] [diff] [review]
Turn on overscrolling by default (Gecko part)

Updated to address review comment. Carrying r+.
Attachment #8435857 - Attachment is obsolete: true
Attachment #8435980 - Flags: review+
The tree closed before I could land this, but it is ready to land.
Keywords: checkin-needed
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Depends on: 1022719
Depends on: 1023459
Depends on: 1025507
Duplicate of this bug: 1026116
Depends on: 1026116
Depends on: 1027068
Depends on: 1026793
Depends on: 1027309
Depends on: 1027633
Depends on: 1023506
Depends on: 1029971
Depends on: 1026683
Depends on: 1030429
Depends on: 1030221
Depends on: 1031024
Depends on: 1031067
Depends on: 1033398
Depends on: 1034733
Depends on: 1034376
Depends on: 1035261
No longer depends on: 1034376
Depends on: 1034376
Depends on: 1035598
Depends on: 1036307
Depends on: 1039733
Depends on: 1030418
Depends on: 1041471
Depends on: 1049795
Depends on: 1050812
Depends on: 1050789
Depends on: 1052121
Depends on: 1054574
We should look through the dependency list for this bug and ensure any important fixes are uplifted to 2.0.
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #14)
> We should look through the dependency list for this bug and ensure any
> important fixes are uplifted to 2.0.

The following dependencies are not fixed in 2.0:

 - bug 1035598
 - bug 1036119
 - bgu 1037191

(I'm not counting bug 1031024 which is test-only code.)

I think it would be good to uplift bug 1035598 and bug 1036119, although their fixes are not super-low-risk as they make changes to AsyncCompositionManager.

For bug 1037191, see https://bugzilla.mozilla.org/show_bug.cgi?id=1037191#c8.
Ok, please request uplift on the bugs that you think should be uplifted. If you're not sure then request uplift anyway and let the release drivers decide.
This was disabled in 2.0 in bug 1064401.
status-b2g-v2.0: --- → disabled
status-b2g-v2.0M: --- → disabled
See Also: → bug 1064401
Depends on: 1073250
Depends on: 1064527
Depends on: 1042103
Depends on: 1098654
Depends on: 1113068
Depends on: 1113457
You need to log in before you can comment on or make changes to this bug.