Bug 1020045 (apz-overscroll)

[meta] Enable APZ overscroll effect

RESOLVED FIXED in mozilla32

Status

()

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: kats, Assigned: botond)

Tracking

({meta})

unspecified
mozilla32
All
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.0 disabled, b2g-v2.0M disabled)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Tracking bug
Keywords: meta
(Assignee)

Comment 1

5 years ago
As per our discussion with Milan this morning, we are turning on overscrolling by default. Note: bug 1018255 will land together with this; the other dependencies should be fixed in the coming days.
Assignee: nobody → botond
Attachment #8435857 - Flags: review?(bugmail.mozilla)
(Assignee)

Comment 2

5 years ago
Attachment #8435860 - Flags: review?(bugmail.mozilla)
(Assignee)

Comment 3

5 years ago
greentry
Combined Try push for bug 1018255 and this bug: https://tbpl.mozilla.org/?tree=Try&rev=d88bfc86e7f5
(Assignee)

Comment 4

5 years ago
(P.S. Yay for only having to change the pref value in 4 places ;-)).
Comment on attachment 8435857 [details] [diff] [review]
Turn on overscrolling by default (Gecko part)

Review of attachment 8435857 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxPrefs.h
@@ +120,5 @@
>    DECL_GFX_PREF(Once, "apz.max_velocity_inches_per_ms",        APZMaxVelocity, float, -1.0f);
>    DECL_GFX_PREF(Once, "apz.max_velocity_queue_size",           APZMaxVelocityQueueSize, uint32_t, 5);
>    DECL_GFX_PREF(Live, "apz.min_skate_speed",                   APZMinSkateSpeed, float, 1.0f);
>    DECL_GFX_PREF(Live, "apz.num_paint_duration_samples",        APZNumPaintDurationSamples, int32_t, 3);
> +  DECL_GFX_PREF(Live, "apz.overscroll.enabled",                APZOverscrollEnabled, bool, true);

Leave this one as false. The b2g.js overrides this, and we don't want it enabled on metro, if that's still a thing.
Attachment #8435857 - Flags: review?(bugmail.mozilla) → review+
Attachment #8435860 - Flags: review?(bugmail.mozilla) → review+
(Assignee)

Comment 6

5 years ago
Updated to address review comment. Carrying r+.
Attachment #8435857 - Attachment is obsolete: true
Attachment #8435980 - Flags: review+
(Assignee)

Updated

5 years ago
Attachment #8435980 - Flags: checkin+
(Assignee)

Comment 7

5 years ago
The tree closed before I could land this, but it is ready to land.
Keywords: checkin-needed
(Assignee)

Comment 9

5 years ago
landing-ish
PR for Gaia patch:

https://github.com/mozilla-b2g/gaia/pull/20161
https://hg.mozilla.org/mozilla-central/rev/78c20dbe259e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Depends on: 1022719
(Assignee)

Updated

5 years ago
Depends on: 1023473
Depends on: 1023459
(Assignee)

Updated

5 years ago
Depends on: 1025436
Depends on: 1025507
Duplicate of this bug: 1026116
Depends on: 1026116
Depends on: 1027068
Depends on: 1026793
Depends on: 1027309
Depends on: 1027633
Depends on: 1023506
Depends on: 1029971
Depends on: 1026683
Depends on: 1030429
Depends on: 1030221
Depends on: 1031024
Depends on: 1031067
Depends on: 1033398
Depends on: 1034733
Depends on: 1034376
Depends on: 1035261
No longer depends on: 1034376
Depends on: 1034376
Depends on: 1035598
(Assignee)

Updated

5 years ago
Depends on: 1036119
Depends on: 1036307
(Assignee)

Updated

5 years ago
Depends on: 1037180
(Assignee)

Updated

5 years ago
Depends on: 1037191
Depends on: 1039733
Depends on: 1030418
Depends on: 1041471
Depends on: 1049795
Depends on: 1050812
Depends on: 1050789
Depends on: 1052121
Depends on: 1054574
We should look through the dependency list for this bug and ensure any important fixes are uplifted to 2.0.
(Assignee)

Comment 15

5 years ago
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #14)
> We should look through the dependency list for this bug and ensure any
> important fixes are uplifted to 2.0.

The following dependencies are not fixed in 2.0:

 - bug 1035598
 - bug 1036119
 - bgu 1037191

(I'm not counting bug 1031024 which is test-only code.)

I think it would be good to uplift bug 1035598 and bug 1036119, although their fixes are not super-low-risk as they make changes to AsyncCompositionManager.

For bug 1037191, see https://bugzilla.mozilla.org/show_bug.cgi?id=1037191#c8.
Ok, please request uplift on the bugs that you think should be uplifted. If you're not sure then request uplift anyway and let the release drivers decide.
(Assignee)

Updated

5 years ago
Depends on: 1046013
This was disabled in 2.0 in bug 1064401.
See Also: → 1064401
Depends on: 1073250
(Assignee)

Updated

5 years ago
Depends on: 1073618
Depends on: 1064527
Depends on: 1042103
Depends on: 1098654
Depends on: 1113068
Depends on: 1113457
You need to log in before you can comment on or make changes to this bug.