Closed
Bug 1020065
Opened 10 years ago
Closed 10 years ago
[Settings] There is a racing between settings.js and connectivity.js
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: arthurcc, Assigned: arthurcc)
Details
Attachments
(1 file)
In main.js we load both settings.js and connectivity.js but connectivity.js depends on settings.js. Which results in the racing between the two files and the following errors.
E/GeckoConsole( 1202): [JavaScript Error: "ReferenceError: Settings is not defined" {file: "app://settings.gaiamobile.org/js/connectivity.js" line: 36}]
E/GeckoConsole( 1215): [JavaScript Error: "TypeError: this.Connectivity is undefined" {file: "app://settings.gaiamobile.org/js/settings.js" line: 118}]
|
Assignee | |
Comment 1•10 years ago
|
||
EJ, the patch was composed as what we discussed. Could you help review it? Thanks.
Attachment #8433830 -
Flags: review?(ejchen)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8433830 [details] Link to https://github.com/mozilla-b2g/gaia/pull/19972 It looks nice to me ! r+
Attachment #8433830 -
Flags: review?(ejchen) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
master: 209bab5d2853831b6d7aa65b231db75b4eefa7c3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•