Closed Bug 1020108 Opened 6 years ago Closed 6 years ago

Use DOMTimestamp in MozCellBroadcastMessage

Categories

(Firefox OS Graveyard :: RIL, defect, critical)

ARM
Gonk (Firefox OS)
defect
Not set
critical

Tracking

(firefox30 unaffected, firefox31 unaffected, firefox32 fixed, firefox33 fixed, firefox-esr31 unaffected, b2g18 wontfix, b2g-v1.1hd wontfix, b2g-v1.2 wontfix, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed, b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
2.0 S3 (6june)
Tracking Status
firefox30 --- unaffected
firefox31 --- unaffected
firefox32 --- fixed
firefox33 --- fixed
firefox-esr31 --- unaffected
b2g18 --- wontfix
b2g-v1.1hd --- wontfix
b2g-v1.2 --- wontfix
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: vicamo, Assigned: vicamo)

References

Details

(Keywords: dev-doc-needed, sec-critical, Whiteboard: [p=1])

User Story

+++ This bug was initially created as a clone of Bug #939302 +++

The patch in bug 927711 added a "jsval" member to MmsDeliveryInfo but didn't add any code to trace the resulting values.  Since these structs are stored on the heap, that means that they value they're holding can just become garbage any time a GC happens.

I strongly recommend, in this order of checkins:

1) Using a numeric timestamp here, not a Date object.
2) Not using xpidl dictionaries.
3) Not using JSAPI directly, because any attempt to do so will generally go wrong.

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #939302 +++
Whiteboard: [qa-]
MozCellbroadcastMessage::timestamp is never referenced in Gaia.  See https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/cell_broadcast_system.js .
Attached patch patchSplinter Review
Assignee: nobody → vyang
Attachment #8433923 - Flags: review?(gene.lian)
Blocks: 864484
Sorry, bug 945322 is for DOM Contacts, somehow missed this.
Comment on attachment 8433923 [details] [diff] [review]
patch

Review of attachment 8433923 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me but have you checked the compatibilities with Gaia? We have to make sure Gaia doesn't use getTime() either before landing.
Attachment #8433923 - Flags: review?(gene.lian) → review+
(In reply to Gene Lian [:gene] (needinfo? encouraged) from comment #6)
> Looks good to me but have you checked the compatibilities with Gaia? We have
> to make sure Gaia doesn't use getTime() either before landing.

See comment 1.
Bug 939302 was uplifted to 1.3, so I originally think this might deserve 1.3 as well.  However, this attribute has never ever been referenced in Gaia, and CellBroadcast is only accessible in privileged apps (System app actually), so I'm not going to ask for 1.3? here.
Whiteboard: [p=1]
https://hg.mozilla.org/mozilla-central/rev/5d28e6b95af5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S3 (6june)
Group: core-security
You need to log in before you can comment on or make changes to this bug.