Closed Bug 1020155 Opened 10 years ago Closed 10 years ago

Populate collection datastore with data defined in pre_installed_collections.json

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.0 fixed)

RESOLVED FIXED
2.0 S3 (6june)
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: crdlc, Assigned: crdlc)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

1) Load and parse file
2) Populate datastore with the descriptors defined in that file generated in build time
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Blocks: 1016225
Depends on: 1020152
Blocks: 1020158
Whiteboard: [systemsfe]
Summary: Populate collection datastore with data defined in pre_defined_collections.json → Populate collection datastore with data defined in pre_installed_collections
Summary: Populate collection datastore with data defined in pre_installed_collections → Populate collection datastore with data defined in pre_installed_collections.json
Attached file Github pull request
10x
Attachment #8434877 - Flags: review?(kgrandon)
Attachment #8434877 - Flags: review?(amirn)
Comment on attachment 8434877 [details]
Github pull request

I'm not comfortable with the name `Initializer` because it implies a process that runs on every launch, when in fact it runs only on FTU.
ftl -> first time launch? setup?
Comment on attachment 8434877 [details]
Github pull request

As there is no way to test this until all the other pieces are in place r+
Attachment #8434877 - Flags: review?(amirn) → review+
Comments addressed until Kevin's review

init.html -> setup.html

Initializer -> Configurator
why not Initializer -> Setup ?
ok changing again :)
done Amir, 10x
Comment on attachment 8434877 [details]
Github pull request

Took a quick scan and looks good to me. I have some concern about the 'setup' connection conflicting with other messages in the future, but I think we should be fine for now. Thanks!
Attachment #8434877 - Flags: review?(kgrandon) → review+
Merged in master:

https://github.com/mozilla-b2g/gaia/commit/cdcc41972e853e2843ee06d850d7add706604d34
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S3 (6june)
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
No longer blocks: 1020158
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: