Populate collection datastore with data defined in pre_installed_collections.json

RESOLVED FIXED in Firefox OS v2.0

Status

Firefox OS
Gaia::Everything.me
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: crdlc, Assigned: crdlc)

Tracking

unspecified
2.0 S3 (6june)
All
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(b2g-v2.0 fixed)

Details

(Whiteboard: [systemsfe])

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
1) Load and parse file
2) Populate datastore with the descriptors defined in that file generated in build time
(Assignee)

Updated

4 years ago
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
(Assignee)

Updated

4 years ago
Blocks: 1016225
Depends on: 1020152
(Assignee)

Updated

4 years ago
Blocks: 1020158
Whiteboard: [systemsfe]
(Assignee)

Updated

4 years ago
Summary: Populate collection datastore with data defined in pre_defined_collections.json → Populate collection datastore with data defined in pre_installed_collections
(Assignee)

Updated

4 years ago
Summary: Populate collection datastore with data defined in pre_installed_collections → Populate collection datastore with data defined in pre_installed_collections.json
(Assignee)

Comment 1

4 years ago
Created attachment 8434877 [details]
Github pull request

10x
Attachment #8434877 - Flags: review?(kgrandon)
Attachment #8434877 - Flags: review?(amirn)

Comment 2

4 years ago
Comment on attachment 8434877 [details]
Github pull request

I'm not comfortable with the name `Initializer` because it implies a process that runs on every launch, when in fact it runs only on FTU.
(Assignee)

Comment 3

4 years ago
ftl -> first time launch? setup?

Comment 4

4 years ago
Comment on attachment 8434877 [details]
Github pull request

As there is no way to test this until all the other pieces are in place r+
Attachment #8434877 - Flags: review?(amirn) → review+
(Assignee)

Comment 5

4 years ago
Comments addressed until Kevin's review

init.html -> setup.html

Initializer -> Configurator

Comment 6

4 years ago
why not Initializer -> Setup ?
(Assignee)

Comment 7

4 years ago
ok changing again :)
(Assignee)

Comment 8

4 years ago
done Amir, 10x
Comment on attachment 8434877 [details]
Github pull request

Took a quick scan and looks good to me. I have some concern about the 'setup' connection conflicting with other messages in the future, but I think we should be fine for now. Thanks!
Attachment #8434877 - Flags: review?(kgrandon) → review+
(Assignee)

Comment 10

4 years ago
Merged in master:

https://github.com/mozilla-b2g/gaia/commit/cdcc41972e853e2843ee06d850d7add706604d34
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S3 (6june)
Mass modify - set status-b2g-v2.0 fixed for fixed bugs under vertical homescreen dependency tree.
status-b2g-v2.0: --- → fixed

Updated

4 years ago
No longer blocks: 1020158
You need to log in before you can comment on or make changes to this bug.