Status

defect
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

(Blocks 1 bug)

Trunk
mozilla32
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch Patch v1 (obsolete) — Splinter Review
No description provided.
Attachment #8433980 - Flags: review?(mshal)
Assignee

Comment 1

5 years ago
Posted patch Patch v2Splinter Review
Apparently JS likes mfbt/Makefile.in to be around; not going to investigate right now.
Attachment #8433980 - Attachment is obsolete: true
Attachment #8433980 - Flags: review?(mshal)
Attachment #8434081 - Flags: review?(mshal)
Comment on attachment 8434081 [details] [diff] [review]
Patch v2

Maybe just remove the 'js/src/export: mfbt/export' line from m-c/Makefile.in? I'm not sure if it's still needed.
Attachment #8434081 - Flags: review?(mshal) → review+
(In reply to Michael Shal [:mshal] from comment #2)
> Comment on attachment 8434081 [details] [diff] [review]
> Patch v2
> 
> Maybe just remove the 'js/src/export: mfbt/export' line from
> m-c/Makefile.in? I'm not sure if it's still needed.

It is.
(In reply to Mike Hommey [:glandium] from comment #3)
> (In reply to Michael Shal [:mshal] from comment #2)
> > Maybe just remove the 'js/src/export: mfbt/export' line from
> > m-c/Makefile.in? I'm not sure if it's still needed.
> 
> It is.

Can you clarify why? Try is green without it and the mfbt/Makefile.in
Ah my bad, it's not since bug 969164.
Assignee

Comment 6

5 years ago
Removed mfbt/Makefile.in as well:

https://hg.mozilla.org/integration/mozilla-inbound/rev/7831570b3ae4
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/7831570b3ae4
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32

Updated

a year ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.