1020167 - [Single Variant] Add search engine configuration based on MCC/MNC

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Description

[Albert [:albert]]

Add single variant configuration to overwrite the search engine settings if provided in an operator customisation, based on MCC/MNC combination:

- search.urlTemplate
- search.suggestionsUrlTemplate
- search.iconUrl
- search.providers

Comment 1

[Albert [:albert]]

Attachment: Patch

Comment 2

[Albert [:albert]]

Patch updated, now it sets the property 'search.providers' with the list of search providers for the mcc/mnc of the SIM.

Comment 3

[Ben Francis [:benfrancis]]

Comment on attachment 8434010 [details]
Patch

Thanks! I had a quick look over this and it looks good, I just left a couple of comments on Github. Will let Yuren do the full review.

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8434010 [details]
Patch

Albert and Ben

the only one issue is property of configuration "iconUrl", since we used iconPath on bug 1009633 and generated iconUri field in build_stage, we should use same property name on bug 1020167, bug 1009633 and bug 1009353.

I propose using iconPath for those three bugs and generate iconUri if needed, does it make sense?

Comment 5

[Albert [:albert]]

For me is ok, I change it.

Ben, it doesn't mean any change in your main code, just in the build process.

Comment 6

[Albert [:albert]]

Comment on attachment 8434010 [details]
Patch

Changed iconUrl by iconPath in json. iconUrl is created at build time.

Comment 7

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8434010 [details]
Patch

thanks!

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

and please update MDN article for this customization.

https://developer.mozilla.org/en-US/Firefox_OS/Developing_Firefox_OS/Market_customizations_guide

Comment 9

[Albert [:albert]]

Master: https://github.com/mozilla-b2g/gaia/commit/8a088f3451a8844803b95446976a972e54b0ccf4

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified on master ( see comment in bug 1031524 )
blocked by bug 1009443 on testing on flame.

Verified fixed on 2.0 buri

Gaia      d9b225fd156b16adabcf459275b52674dde517cc
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/0b5f757da75a
BuildID   20140709000201
Version   32.0a2
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Tester's Note : Albert had set me straight.  bug 1031164 is what I am really blocked on for flame.
This does not handle DSDS cases.  Bug 927709 will handle DSDS cases.