Closed Bug 1020167 Opened 6 years ago Closed 6 years ago

[Single Variant] Add search engine configuration based on MCC/MNC

Categories

(Firefox OS Graveyard :: Gaia::Search, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.0 verified, b2g-v2.1 verified)

VERIFIED FIXED
2.0 S3 (6june)
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- verified

People

(Reporter: albert, Assigned: albert)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

363 bytes, text/html
yurenju
: review+
benfrancis
: feedback+
Details
Add single variant configuration to overwrite the search engine settings if provided in an operator customisation, based on MCC/MNC combination:

- search.urlTemplate
- search.suggestionsUrlTemplate
- search.iconUrl
- search.providers
Blocks: 1009353
Whiteboard: [systemsfe]
Attached file Patch
Attachment #8434010 - Flags: feedback?(bfrancis)
Assignee: nobody → acperez
Target Milestone: --- → 2.0 S3 (6june)
Patch updated, now it sets the property 'search.providers' with the list of search providers for the mcc/mnc of the SIM.
Attachment #8434010 - Flags: review?(yurenju.mozilla)
Comment on attachment 8434010 [details]
Patch

Thanks! I had a quick look over this and it looks good, I just left a couple of comments on Github. Will let Yuren do the full review.
Attachment #8434010 - Flags: feedback?(bfrancis) → feedback+
Comment on attachment 8434010 [details]
Patch

Albert and Ben

the only one issue is property of configuration "iconUrl", since we used iconPath on bug 1009633 and generated iconUri field in build_stage, we should use same property name on bug 1020167, bug 1009633 and bug 1009353.

I propose using iconPath for those three bugs and generate iconUri if needed, does it make sense?
Attachment #8434010 - Flags: review?(yurenju.mozilla)
Flags: needinfo?(bfrancis)
Flags: needinfo?(acperez)
For me is ok, I change it.

Ben, it doesn't mean any change in your main code, just in the build process.
Flags: needinfo?(acperez)
Comment on attachment 8434010 [details]
Patch

Changed iconUrl by iconPath in json. iconUrl is created at build time.
Attachment #8434010 - Flags: review?(yurenju.mozilla)
Comment on attachment 8434010 [details]
Patch

thanks!
Attachment #8434010 - Flags: review?(yurenju.mozilla) → review+
Master: https://github.com/mozilla-b2g/gaia/commit/8a088f3451a8844803b95446976a972e54b0ccf4
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Flags: needinfo?(bfrancis)
Verified on master ( see comment in bug 1031524 )
blocked by bug 1009443 on testing on flame.

Verified fixed on 2.0 buri

Gaia      d9b225fd156b16adabcf459275b52674dde517cc
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/0b5f757da75a
BuildID   20140709000201
Version   32.0a2
ro.build.version.incremental=324
ro.build.date=Thu Dec 19 14:04:55 CST 2013
Status: RESOLVED → VERIFIED
Tester's Note : Albert had set me straight.  bug 1031164 is what I am really blocked on for flame.
This does not handle DSDS cases.  Bug 927709 will handle DSDS cases.
You need to log in before you can comment on or make changes to this bug.