1020194 - [Clock]Missing images

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Helen Huang [:HHuang]]

Base on Pavel's feedback, there's some missing images that need to update.

Comment 1

[Helen Huang [:HHuang]]

Attachment: Clock missing images.zip

Hi Pavel, 

There are missing images for Clock, please help to update them, thanks!

Below images might not needed since we're using new button style which is pill shape, so those two looks outdated.
./apps/clock/style/images/[e-mail]
./apps/clock/style/images/[e-mail]
./apps/clock/style/images/[e-mail]
./apps/clock/style/images/[e-mail]

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Hey Mike,
can you check this one ... I merged the PR by mistake but I think that it's OK
sorry about this one

Comment 3

[Jason Smith [:jsmith]]

Comment on attachment 8434103 [details] [review]
patch for Gaia/master

We no longer work with Bocoup on Firefox OS, so I think you want Marcus here for a review.

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Oh sorry ... I did not know this. Thanks :)

Comment 5

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8434103 [details] [review]
patch for Gaia/master

It looks like you already merged this by mistake. It looks OK to me, but the images seem pretty large; I know that e-mail does PNG compression before uploading; have we done similar things for other apps' assets as well? If so, please push another commit with those assets compressed, otherwise looks ok to me.

Comment 6

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: follow-up patch for Gaia/master

yep I just forgot to do this on this patch. Thanks :)

Comment 7

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/096e8add0026f9e5e53a907c0b8d2e08bc1d5f72