UserProfile.objects.public() should include users with public external acounts

REOPENED
Unassigned

Status

Participation Infrastructure
Phonebook
REOPENED
4 years ago
4 years ago

People

(Reporter: giorgos, Unassigned)

Tracking

Details

(Reporter)

Description

4 years ago
UserProfile.objects.public() manager method does not take into account the privacy settings of external accounts. 

If a user has only external accounts set to be public then we don't include them in the public profiles list.

This is an edge case and does not expose any private data but it should be fixed anyway.
(Reporter)

Comment 1

4 years ago
Must also update the UserProfile.is_public method
(Reporter)

Comment 2

4 years ago
We fixed it in bug 1001342 so that when deleting a UserProfile object the related User object gets deleted too.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
(Reporter)

Comment 3

4 years ago
Ignore comment #2, wrong bug.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Couple of questions:
-Does this bug wants the user to be logged in and vouched, logged in and not vouched, not not logged in, or all of the above?
-Is this searching on full_name, email, or ircname? Or does it matter?
(Reporter)

Comment 5

4 years ago
This is about how a UserProfile method should behave and not directly related to a logged in or logged out user. 

UserProfile.objects.all() returns all user profiles
UserProfile.objects.public() should return users profiles with at least one field set to public. Currently it ignores the status of external accounts, meaning that if a user only has "linkedin" set to public and none of all the other fields of their profile, they are not included in the list generated by UserProfile.objects.public()
You need to log in before you can comment on or make changes to this bug.