1020269 - UserProfile.objects.public() should include users with public external acounts

Status: NEW

(Participation Infrastructure :: Phonebook, defect)

Description

[Giorgos Logiotatidis [:giorgos]]

UserProfile.objects.public() manager method does not take into account the privacy settings of external accounts. 

If a user has only external accounts set to be public then we don't include them in the public profiles list.

This is an edge case and does not expose any private data but it should be fixed anyway.

Comment 1

[Giorgos Logiotatidis [:giorgos]]

Must also update the UserProfile.is_public method

Comment 2

[Giorgos Logiotatidis [:giorgos]]

We fixed it in bug 1001342 so that when deleting a UserProfile object the related User object gets deleted too.

Comment 3

[Giorgos Logiotatidis [:giorgos]]

Ignore comment #2, wrong bug.

Comment 4

[Teri Charles [:tericharles]]

Couple of questions:
-Does this bug wants the user to be logged in and vouched, logged in and not vouched, not not logged in, or all of the above?
-Is this searching on full_name, email, or ircname? Or does it matter?

Comment 5

[Giorgos Logiotatidis [:giorgos]]

This is about how a UserProfile method should behave and not directly related to a logged in or logged out user. 

UserProfile.objects.all() returns all user profiles
UserProfile.objects.public() should return users profiles with at least one field set to public. Currently it ignores the status of external accounts, meaning that if a user only has "linkedin" set to public and none of all the other fields of their profile, they are not included in the list generated by UserProfile.objects.public()