1020296 - Improve readability of Python exception regex

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Comment 1

[Ed Morley [:emorley]]

Now that mozharness has been updated, we need to prevent matches against the non-TEST-UNEPXECTED-FAIL lines in:

(bug 1012984):
{
09:19:46     INFO -  TimeoutException: TimeoutException: Connection timed out
...
09:19:46    ERROR -  TEST-UNEXPECTED-FAIL | test_battery_status_charging.js | TimeoutException: TimeoutException: Connection timed out
}


ScriptTimeoutException instance seems fine already:

(Bug 1019957):
{
01:43:25     INFO -  ======================================================================
01:43:25     INFO -  ERROR: None
01:43:25     INFO -  ----------------------------------------------------------------------
01:43:25    ERROR -  TEST-UNEXPECTED-FAIL | test_success_in_oop.js | ScriptTimeoutException: ScriptTimeoutException: timed out
}

(bug 1019062):
{
08:04:23     INFO -      raise ScriptTimeoutException(message=message, status=status, stacktrace=stacktrace)
08:04:23    ERROR -  TEST-UNEXPECTED-FAIL | test_settings_do_not_track.py test_settings_do_not_track.TestSettingsDoNotTrack.test_enable_do_not_track_via_settings_app | ScriptTimeoutException: ScriptTimeoutException: timed out
}
(since we don't match against "    raise ...")

Same for NoSuchElementException:

(bug 951654):
{
09:32:24     INFO -      raise NoSuchElementException(message=message, status=status, stacktrace=stacktrace)
09:32:24    ERROR -  TEST-UNEXPECTED-FAIL | test_implicit_waits.py test_implicit_waits.TestImplicitWaits.testShouldImplicitlyWaitForASingleElement | NoSuchElementException: NoSuchElementException: Unable to locate element: box0
}

Comment 2

[Ed Morley [:emorley]]

Attachment: Simplify the regex for exclusion of Marionette timeout exceptions

Restores the /^[A-Za-z.]*Exception: / line that was there previously, and adds a simpler blacklist just for the timeouts, since even after hunting for some time, I couldn't find examples of the others that we'd match against (see comment 1). Seems to work well locally.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8438546 [details] [diff] [review]
Simplify the regex for exclusion of Marionette timeout exceptions

Review of attachment 8438546 [details] [diff] [review]:
-----------------------------------------------------------------

Holy cow, that's a lot simpler. Fully trust you on your local testing.

Comment 4

[Ed Morley [:emorley]]

Thank you for the reviews :-)

https://hg.mozilla.org/webtools/tbpl/rev/888593c6f266

Comment 5

[Ed Morley [:emorley]]

This was in production on 2014-06-12, forgot to update the bug then.