1020406 - Refactor database abstraction layer in Login

Status: RESOLVED FIXED

(Webmaker Graveyard :: Login, defect)

Description

[inactivate account for kate]

Right now we only have access to a single model. Let's expose the model(s) directly so we have more flexibility

Comment 1

[inactivate account for kate]

Attachment: https://github.com/mozilla/login.webmaker.org/pull/274/files

So I took a crack at this, basically what I tried to do in this patch was: 

* refactor /models to be /db, and initialize the DB separately from the model definitions
* expose an object containing User, which includes the controller methods 
* consolidate the API in the user model/user controller files into a single API

Comment 2

[Jon Buckley [:jbuck]]

Comment on attachment 8434410 [details]
https://github.com/mozilla/login.webmaker.org/pull/274/files

this looks like a pretty good set of changes overall. Some minor things to fix up noted in the PR.

I'm not sure of the timing of this landing vs the new functionality and I were working on. Lets discuss tomorrow, and see how we can reduce the pain

Comment 3

[Jon Buckley [:jbuck]]

Comment on attachment 8434410 [details]
https://github.com/mozilla/login.webmaker.org/pull/274/files

I think it'll be ready to land after this last set of changes. Can you also rebase on master? No conflicts fortunately, but master changed a lot today

Comment 4

[inactivate account for kate]

Comment on attachment 8434410 [details]
https://github.com/mozilla/login.webmaker.org/pull/274/files

ok, last few things fixed up

Comment 5

[Jon Buckley [:jbuck]]

Comment on attachment 8434410 [details]
https://github.com/mozilla/login.webmaker.org/pull/274/files

noice. r+ with one nit noted in the PR

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/login.webmaker.org

https://github.com/mozilla/login.webmaker.org/commit/36f594c9ed586bc335ed85beff04999b7e916583
Bug 1020406 - Refactor login to expose multiple models if needed