1020408 - Hide old homescreen in version 2.0 for mobile phones

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Cristian Rodriguez (:crdlc)]

I think that we have to hide the old homescreen app in version 2.0 at least for mobile phones. I don't know if tablets support it or not. If tablets or other devices will use the old homescreen, perhaps, we should implement it at build level thought. 

How could we hide the old homescreen?
We could change the role in the manifest file from homescreen to system.

Comment 1

[Kevin Grandon :kgrandon]

Yuren - do you have any preference as to how we handle this? My initial thoughts are that we could change the manifest in the build step to have role=system for non tablet devices..

On second thought I may have just broken tablets completely with landing the vertical homescreen. Let me make sure I didn't do that yet :)

Comment 2

[Kevin Grandon :kgrandon]

Yuren - Please see comment #1, thanks!

Comment 5

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

not sure what you mean since I don't see homescreen app on current home2, but we have "homescreen.appName" settings value for different device type. For example, tv used "homescreen-stingray" app for homescreen[1].

Gary will update customzation page on MDN[2] for this setting.

[1] https://github.com/mozilla-b2g/gaia/blob/master/build/config/tv/settings.json
[2] https://developer.mozilla.org/en-US/Firefox_OS/Developing_Firefox_OS/Market_customizations_guide

Comment 6

[GaryChen [:GaryChen][:PYChen][:gchen][:陳柏宇]]

(In reply to Cristian Rodriguez (:crdlc) from comment #0)
> I think that we have to hide the old homescreen app in version 2.0 at least
> for mobile phones. I don't know if tablets support it or not. If tablets or
> other devices will use the old homescreen, perhaps, we should implement it
> at build level thought. 
> 
> How could we hide the old homescreen?
> We could change the role in the manifest file from homescreen to system.

Yes, currently we can customize default Homescreen APP through 'setting.json', please refer to the following links.

https://developer.mozilla.org/en-US/Firefox_OS/Developing_Firefox_OS/Market_customizations_guide#Customize_default_Homescreen_APP

Comment 7

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Yuren - I was thinking of something like this, what do you think?

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8436095 [details] [review]
Github pull request

I didn't have enough context for this change but Thanks Tim to help me understand the story about migration for homescreen and browser (both using "system" role for this purpose), so that's good to me, thanks!

Comment 9

[Kevin Grandon :kgrandon]

Landed: https://github.com/mozilla-b2g/gaia/commit/8e803bf91ce792439cc6c11dff657240a4bd8df8