1020432 - Leak of |buf| in nsAuthSambaNTLM::GetNextToken

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Andrew McCreight [:mccr8]]

At the end of this method, it calls ExtractMessage(), which allocates a new buffer, and returns it to |buf|.  Then nothing frees it on success.

Comment 1

[Nochum Sossonko [:Natch]]

Just moving the |free(buf);| call above the if block should do it, no?

Taking.

Comment 2

[Andrew McCreight [:mccr8]]

(In reply to Nochum Sossonko [:Natch] from comment #1)
> Just moving the |free(buf);| call above the if block should do it, no?
Yes, that sounds right to me.

> Taking.
Thanks!

Comment 3

[Nochum Sossonko [:Natch]]

Attachment: free |buf| always when it's successfully allocated

Comment 4

[Andrew McCreight [:mccr8]]

Comment on attachment 8440783 [details] [diff] [review]
free |buf| always when it's successfully allocated

Thanks for the patch!  I'll forward this review to a Necko peer who appear to have done stuff with this file in the past.

Comment 5

[Honza Bambas (:mayhemer)]

Comment on attachment 8440783 [details] [diff] [review]
free |buf| always when it's successfully allocated

Review of attachment 8440783 [details] [diff] [review]:
-----------------------------------------------------------------

thanks, r=honzab

Comment 6

[Nochum Sossonko [:Natch]]

Attachment: free |buf| always when it's successfully allocated

Thanks.

Comment 7

[Andrew McCreight [:mccr8]]

try run: https://tbpl.mozilla.org/?tree=Try&rev=cf9cf18c8f8a

Comment 8

[Andrew McCreight [:mccr8]]

Thanks for the patch!

https://hg.mozilla.org/integration/mozilla-inbound/rev/35c527229cdb

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/35c527229cdb