Closed
Bug 1020432
Opened 10 years ago
Closed 10 years ago
Leak of |buf| in nsAuthSambaNTLM::GetNextToken
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: mccr8, Assigned: Natch, Mentored)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity, memory-leak)
Attachments
(1 file, 1 obsolete file)
722 bytes,
patch
|
Natch
:
review+
|
Details | Diff | Splinter Review |
At the end of this method, it calls ExtractMessage(), which allocates a new buffer, and returns it to |buf|. Then nothing frees it on success.
Updated•10 years ago
|
Whiteboard: [mentor=mccr8] [good first bug]
Assignee | ||
Comment 1•10 years ago
|
||
Just moving the |free(buf);| call above the if block should do it, no?
Taking.
Assignee: nobody → highmind63
Status: NEW → ASSIGNED
Flags: needinfo?(continuation)
Reporter | ||
Comment 2•10 years ago
|
||
(In reply to Nochum Sossonko [:Natch] from comment #1)
> Just moving the |free(buf);| call above the if block should do it, no?
Yes, that sounds right to me.
> Taking.
Thanks!
Flags: needinfo?(continuation)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8440783 -
Flags: review?(continuation)
Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8440783 [details] [diff] [review]
free |buf| always when it's successfully allocated
Thanks for the patch! I'll forward this review to a Necko peer who appear to have done stuff with this file in the past.
Attachment #8440783 -
Flags: review?(continuation) → review?(honzab.moz)
Updated•10 years ago
|
Mentor: continuation
Whiteboard: [mentor=mccr8] [good first bug] → [good first bug]
Comment 5•10 years ago
|
||
Comment on attachment 8440783 [details] [diff] [review]
free |buf| always when it's successfully allocated
Review of attachment 8440783 [details] [diff] [review]:
-----------------------------------------------------------------
thanks, r=honzab
Attachment #8440783 -
Flags: review?(honzab.moz) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Thanks.
Attachment #8440783 -
Attachment is obsolete: true
Attachment #8443099 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Reporter | ||
Comment 7•10 years ago
|
||
Reporter | ||
Comment 8•10 years ago
|
||
Thanks for the patch!
https://hg.mozilla.org/integration/mozilla-inbound/rev/35c527229cdb
Keywords: checkin-needed
Comment 9•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug]
Target Milestone: --- → mozilla33
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•