1020489 - race condition with symbols uploads

Status: RESOLVED INVALID

(Socorro :: Webapp, task)

Description

[Lonnen :lonnen]

If a user uploads a file and we push a release the webapp folder will be archived with the symbols in it. When crontabber runs it won't find them.

I recommend we fix this by making the upload location configurable and in our setup pointing it to a dir outside the webapp.

Comment 1

[Peter Bengtsson [:peterbe]]

As a potentially off-topic issue, we should maybe increase the frequency of the crontabber job to happen more frequently than every hour.

Comment 2

[Daniel Maher [:phrawzty]]

(In reply to Chris Lonnen :lonnen from comment #0)
> I recommend we fix this by making the upload location configurable and in
> our setup pointing it to a dir outside the webapp.

It's my understanding that Django cannot be configured to allow uploads outside of its own tree, which is why the symlink exists under media/ in the first place...

Comment 3

[Peter Bengtsson [:peterbe]]

(In reply to Daniel Maher [:phrawzty] from comment #2)
> (In reply to Chris Lonnen :lonnen from comment #0)
> > I recommend we fix this by making the upload location configurable and in
> > our setup pointing it to a dir outside the webapp.
> 
> It's my understanding that Django cannot be configured to allow uploads
> outside of its own tree, which is why the symlink exists under media/ in the
> first place...

Yes and no. You can't upload files to specific directories but you can set the MEDIA_ROOT settings to something "outside of the its own tree". E.g. `MEDIA_ROOT='/var/data/foo'` in local.py

However, if we some day do other uploads too that aren't symbols, they'll go into that directory too.

Comment 4

[Lonnen :lonnen]

I wasn't aware of the symlink when I filed, so maybe this is moot. I do think that if we're writing to the file system it should be treated like other storage devices and be a configurable path. It would also help with work Rob has been doing to make it easier to deploy onto a paas environment.