Closed Bug 1020510 Opened 6 years ago Closed 6 years ago

let tbody/etc accessible in table hierarchy

Categories

(Core :: Disability Access APIs, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: surkov, Assigned: surkov)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file)

spun off the bug 1005271

we fail to create table hierarchy if tbody etc get an accessible what happens in scrollable tables
Attached patch patchSplinter Review
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #8435169 - Flags: review?(trev.saunders)
Comment on attachment 8435169 [details] [diff] [review]
patch

>+      Accessible* table = aContext->IsTable() ?
>+        aContext :
>+        (aContext->Parent()->IsTable() ? aContext->Parent() : nullptr);
>+
>+      if (table) {
>         nsIContent* parentContent = aContent->GetParent();
>         nsIFrame* parentFrame = parentContent->GetPrimaryFrame();
>-        if (parentFrame->GetType() == nsGkAtoms::tableRowGroupFrame) {
>+        if (parentFrame->GetType() != nsGkAtoms::tableOuterFrame) {
>           parentContent = parentContent->GetParent();
>           parentFrame = parentContent->GetPrimaryFrame();

I sort of wish we had only one check if the parent or grand parent  was the table, but I guess this is fine.

I'm a little worried something might rely on the child of a table being a table row, but I couldn't immediately find anything.
Attachment #8435169 - Flags: review?(trev.saunders) → review+
(In reply to Trevor Saunders (:tbsaunde) from comment #2)

> I sort of wish we had only one check if the parent or grand parent  was the
> table, but I guess this is fine.

it's felt a bit complicated but just keeping closer to original code 

> I'm a little worried something might rely on the child of a table being a
> table row, but I couldn't immediately find anything.

I tried to add some mochitests worrying about same thing but run into bug 1020603.
https://hg.mozilla.org/mozilla-central/rev/d4fc8141e2db
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.