let tbody/etc accessible in table hierarchy

RESOLVED FIXED in mozilla32

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks 1 bug, {access})

unspecified
mozilla32
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

spun off the bug 1005271

we fail to create table hierarchy if tbody etc get an accessible what happens in scrollable tables
Posted patch patchSplinter Review
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #8435169 - Flags: review?(trev.saunders)
Comment on attachment 8435169 [details] [diff] [review]
patch

>+      Accessible* table = aContext->IsTable() ?
>+        aContext :
>+        (aContext->Parent()->IsTable() ? aContext->Parent() : nullptr);
>+
>+      if (table) {
>         nsIContent* parentContent = aContent->GetParent();
>         nsIFrame* parentFrame = parentContent->GetPrimaryFrame();
>-        if (parentFrame->GetType() == nsGkAtoms::tableRowGroupFrame) {
>+        if (parentFrame->GetType() != nsGkAtoms::tableOuterFrame) {
>           parentContent = parentContent->GetParent();
>           parentFrame = parentContent->GetPrimaryFrame();

I sort of wish we had only one check if the parent or grand parent  was the table, but I guess this is fine.

I'm a little worried something might rely on the child of a table being a table row, but I couldn't immediately find anything.
Attachment #8435169 - Flags: review?(trev.saunders) → review+
(In reply to Trevor Saunders (:tbsaunde) from comment #2)

> I sort of wish we had only one check if the parent or grand parent  was the
> table, but I guess this is fine.

it's felt a bit complicated but just keeping closer to original code 

> I'm a little worried something might rely on the child of a table being a
> table row, but I couldn't immediately find anything.

I tried to add some mochitests worrying about same thing but run into bug 1020603.
https://hg.mozilla.org/mozilla-central/rev/d4fc8141e2db
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.