Open Bug 1020576 Opened 10 years ago Updated 2 years ago

DumpHeap in TestingFunctions.cpp fails to close |dumpFile| when it gets bad args

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

People

(Reporter: mccr8, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, memory-leak, Whiteboard: [CID 1123254]) 

This return:
    if (i != args.length()) {
        JS_ReportError(cx, "bad arguments passed to dumpHeapComplete");
        return false;
    }

Need to do something like this:
    if (dumpFile)
        fclose(dumpFile);

(Just a testing function, so no need to track in MemShrink.)
Summary: DumpHeapComplete in TestingFunctions.cpp fails to close |dumpFile| when it gets bad args → DumpHeap in TestingFunctions.cpp fails to close |dumpFile| when it gets bad args
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.